mirrors/arti.git/crates/tor-dirmgr/src/lib.rs, branch tor-dirmgr-v0.5.1

Run maint/add_warning crates/*/src/{lib,main}.rs

2022-06-23T18:15:42Z

Update all lint blocks

Merge branch 'stalled_directory' into 'main'

2022-06-21T19:13:40Z

Detect and report stalled directory downloads Closes #468 See merge request tpo/core/arti!587

Fix clippy::significant_drop_in_scrutinee warnings

2022-06-15T15:52:30Z

This is apparently a new warning from clippy nightly, documented in https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee . I'm not in love with the temporary variables that this warning wants me to introduce, but it does seem like a decent way to avoid some kinds of deadlock.

tor-dirmgr: Make DirStatus non-public.

2022-06-14T15:02:29Z

I believe this type was made public in error: No other crate uses it, and no API exposes it.

Add a blockage-reporting mechanism to tor-dirmgr.

2022-06-14T14:42:18Z

The `DirBootstrapStatus` type now exposes a blockage() method to return an `Option`. The blockage types reported are more low-level than I'd like, but they are IMO good enough for now: we'll want to get experience with actual vs hypothetical problems before we refine them.

DirMgr: Track errors, stalls, and resets as part of status.

2022-06-13T17:58:31Z

A "reset" happens whenever we have to start a download attempt over -- either because we ran out of retries, or we found something wrong with the consensus after fetching certificates. An "error" happens when we have a recoverable error from one or more directory sources. A "stall" happens whenever a round of downloads or cache loads leads to no change in the status. We don't yet use this as part of our status reporting.

Refactor our logic for distinguishing download attempts

2022-06-13T17:21:09Z

Previously we used the "if-modified-since" time associated with the consensus download, and/or the "valid-after" time in the consensus attempt, to put multiple attempts into sequence, and to tell one from another. But that approach was always a kludge, and will soon get more unreliable as the DirStatus logic gets a bit more complex. With this commit, we change separate download attempts to be identified with an AttemptId that increments whenever we decide to get a different directory from the one we have. IMO this new code is _much_ cleaner.

Refactor most DirStatus users to use DirProgress.

2022-06-13T16:22:04Z

This is all crate-internal APIs, fortunately.

Merge branch 'dormant_directory' into 'main'

2022-06-13T13:59:26Z

Use TaskSchedule to sleep in directory bootstrapping Closes #497 See merge request tpo/core/arti!571

DirMgr: Use scopeguard crate in place of ad hoc RAII substitutes

2022-06-13T12:28:41Z