mirrors/arti.git/crates/tor-dirmgr/src/lib.rs, branch arti-v0.6.0

tor-dirmgr: Remove opt_netdir entirely.

2022-07-26T09:41:38Z

Its existence tended to hide bugs, and was just asking for trouble.

Remove unused DirMgr::netdir method, make opt_netdir private.

2022-07-26T09:41:06Z

Add new APIs to NetDirProvider to better support timeliness.

2022-07-26T09:40:53Z

Over the years we've found that most callers who want a netdir want what C Tor calls a "reasonably live" network directory: One that is not expired by too much, or too far in the future. But a few want a _strictly_ live directory: one that says it is valid now, with no tolerances. And a few want _any_ directory, no matter how expired it is. This commit adds net methods to NetDirProvider to provide these directories. I think that most use cases will want to explicitly think about what kind of directory they want, so I've made `netdir` the simplest method. I might remove `timely_netdir` by the end of this branch; see TODO comments. Part of #518.

Rename DirSkewTolerance to DirTolerance

2022-07-22T14:04:25Z

This name is more accurate because we aren't only dealing with clock skew here: we're also trying to tolerate the case where the authorities fail to reach consensus for a while.

Run maint/add_warning crates/*/src/{lib,main}.rs

2022-06-23T18:15:42Z

Update all lint blocks

Merge branch 'stalled_directory' into 'main'

2022-06-21T19:13:40Z

Detect and report stalled directory downloads Closes #468 See merge request tpo/core/arti!587

Fix clippy::significant_drop_in_scrutinee warnings

2022-06-15T15:52:30Z

This is apparently a new warning from clippy nightly, documented in https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee . I'm not in love with the temporary variables that this warning wants me to introduce, but it does seem like a decent way to avoid some kinds of deadlock.

tor-dirmgr: Make DirStatus non-public.

2022-06-14T15:02:29Z

I believe this type was made public in error: No other crate uses it, and no API exposes it.

Add a blockage-reporting mechanism to tor-dirmgr.

2022-06-14T14:42:18Z

The `DirBootstrapStatus` type now exposes a blockage() method to return an `Option`. The blockage types reported are more low-level than I'd like, but they are IMO good enough for now: we'll want to get experience with actual vs hypothetical problems before we refine them.

DirMgr: Track errors, stalls, and resets as part of status.

2022-06-13T17:58:31Z

A "reset" happens whenever we have to start a download attempt over -- either because we ran out of retries, or we found something wrong with the consensus after fetching certificates. An "error" happens when we have a recoverable error from one or more directory sources. A "stall" happens whenever a round of downloads or cache loads leads to no change in the status. We don't yet use this as part of our status reporting.