mirrors/arti.git/crates/tor-dirmgr/src/lib.rs, branch arti-v0.4.0

Remove BootstrapAction::Impossible

2022-05-19T12:00:41Z

It does nothing that Fatal does not. Suggested by @eta in review.

DirMgr: Unify error return paths

2022-05-17T16:25:32Z

We no longer have separate return paths for recoverable and fatal errors; instead, they are merged, and distinguished based on recovery actions. Since it is now possible for download() to give an error that should _not_ destroy the previous state, it takes `&mut Box`. This change unfortunately means that we can no longer call `state = state.advance()`, but instead have to do some mem::swap junk with poisoned values. Any better solution would be a good thing. Additionally, the reset() and advance() methods can no longer fail. There is still a separate return path for reset-triggering errors; I'm about to fix that.

DirMgr: Improve display for DocSource

2022-05-16T16:42:25Z

(Also, implement Display for tor_dirclient::SourceInfo).

DirMgr: make DocSource useful by having it include dirserver info.

2022-05-16T16:42:25Z

Previously DocSource would tell you whether the document was from a local store or a cache server, but it wouldn't tell you _which_ server it came from. This change required adding DocSource as an argument to DirState::add_from_download.

Resolve DOCDOC comments in tor-dirmgr.

2022-05-12T13:45:05Z

Adjust if-modified-since field on the basis of tolerated skew

2022-05-11T16:36:51Z

If we're happy with a directory from 3 days ago, we should say "if-modified-since 3 days ago". This patch is larger than I'd like, since I had to add &DirMgrConfig as an argument to the functions that make a consensus request. Closes #467.

Add DirSkewTolerance section to DirMgr configuration.

2022-05-11T16:11:17Z

This new section describes how much variance we accept when it comes to expired and not-yet-valid directory documents. (Currently, the only ones where this matters for are consensus documents and authority certificates.) A document that is invalid by no more than these tolerances is not _live_, but it can still be used. These tolerances serve two purposes: * First, they allow clients to run with a little more clock skew than they would tolerate otherwise. * Second, they allow clients to survive the situation where the authorities are unable to reach a consensus for a day or two. Compare with Tor's REASONABLY_LIVE_TIME and NETWORKSTATUS_ALLOW_SKEW constants; also compare with proposal 212. Closes #412.

tor-dirmgr: move apply_netdir_changes() to be a DirMgr method

2022-05-10T12:29:39Z

tor-dirmgr/state.rs: take an object to get a netdir, not a netdir

2022-05-10T12:29:39Z

- Taking a previous netdir directly and keeping it around before we need it is a bit of a waste of memory, and also doesn't mesh well with how SharedMutArc works. - To remedy this, introduce a new trait `PreviousNetDir` and have the state machines take that instead. (I was a bit tempted to just pass in the SharedMutArc directly. Maybe I should've done that.)

tor-dirmgr/state.rs: remove GetConsensusState::bodge_new

2022-05-10T10:50:07Z

- (Also fixes up some dirfilter stuff, whoops.)