mirrors/arti.git/crates/tor-dirmgr/src/lib.rs, branch arti-v0.3.0

tor-dirmgr: make DownloadScheduleBuilder public

2022-05-04T12:50:12Z

This type was returned by the public DownloadSchedule::builder function. But the only thing that seems to have noticed that the type name itself wasn't exported, was rustdoc. Hmmm.

Change builder list API

2022-05-04T12:50:10Z

The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements).

DirMgrConfig: Remove unnecessary accessors

2022-04-26T14:32:20Z

These fields are pub. Retain two convenience accessor functions that access sub-fields of network.

DownloadSchedule: Abolish accessors in DownloadScheduleConfig

2022-04-26T14:16:32Z

We can just make the fields pub(crate).

Introduce AuthorityListBuilder in NetworkConfigBuilder

2022-04-25T11:54:51Z

NetworkConfigBuilder needs to not contain any validated structs, so that its serde does not expose the validated details. AuthorityListBuilder is what ought to go here - and it contains Vec, not Vec. As a consequence, many places now deal with AuthorityBuilder, rather than Authority.

Refactor FirstHopId into type-differentiated form

2022-03-30T14:41:39Z

The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard.

Rename Guard=>FirstHop, GuardId=>FirstHopId

2022-03-30T14:40:59Z

This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index.

Rename ExternalFailure => ExternalActivity.

2022-03-30T14:40:12Z

Add status tracking to FallbackDir.

2022-03-30T14:39:09Z

We do this by creating a new FallbackSet type that includes status information, and updating the GuardMgr APIs to record success and failure about it when appropriate. We can use this to mark FallbackDirs retriable (or not). With this change, FallbackDir is now stored internally as a Guard in the GuardMgr crate. That's fine: the FallbackDir type really only matters for configuration.

Move fallback.rs into guardmgr.

2022-03-30T14:34:48Z

This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects.