mirrors/arti.git/crates/tor-dirmgr/src/lib.rs, branch arti-v0.2.0

Refactor FirstHopId into type-differentiated form

2022-03-30T14:41:39Z

The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard.

Rename Guard=>FirstHop, GuardId=>FirstHopId

2022-03-30T14:40:59Z

This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index.

Rename ExternalFailure => ExternalActivity.

2022-03-30T14:40:12Z

Add status tracking to FallbackDir.

2022-03-30T14:39:09Z

We do this by creating a new FallbackSet type that includes status information, and updating the GuardMgr APIs to record success and failure about it when appropriate. We can use this to mark FallbackDirs retriable (or not). With this change, FallbackDir is now stored internally as a Guard in the GuardMgr crate. That's fine: the FallbackDir type really only matters for configuration.

Move fallback.rs into guardmgr.

2022-03-30T14:34:48Z

This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects.

Make daemon tasks self-contained; introduce NetDirProvider

2022-03-30T13:26:43Z

The various background daemon tasks that `arti-client` used to spawn are now handled inside their respective crates instead, with functions provided to spawn them that return `TaskHandle`s. This required introducing a new trait, `NetDirProvider`, which steals some functionality from the `DirProvider` trait to enable `tor-circmgr` to depend on it (`tor-circmgr` is a dependency of `tor-dirmgr`, so it can't depend on `DirProvider` directly). While we're at it, we also make some of the tasks wait for events from the `NetDirProvider` instead of sleeping, slightly increasing efficiency.

Merge branch 'no-system-time' into 'main'

2022-03-30T12:44:25Z

Don't use SystemTime::now() Closes #306 See merge request tpo/core/arti!365

Abolish filter::DynFilter in favour of transparent DirFilter

2022-03-25T13:08:56Z

There are two reasons why the DynFilter newtype might be needed: 1. To impl Default. But we don't need it to impl Default since we can have an accessor which does the defaulting. 2. To hide the API. But this is usrely an unstable API. Just writing Arc gets rid of a lot of unnecessary boilerplate and conversion code.

dirmgr: Initial DirFilter code.

2022-03-24T16:10:46Z

This code sits behind a feature flag, and can be used to modify directories before storing them. This is part of the implementation for #397.

Expand some comments based on review from @diziet.

2022-03-21T19:16:00Z