mirrors/arti.git/crates/tor-dirmgr/src/err.rs, branch tor-dirmgr-v0.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-06-21T18:14:14Z Do not include error source() in display() format. 2022-06-21T18:14:14Z Nick Mathewson nickm@torproject.org 2022-06-21T18:14:14Z urn:sha1:08d9bbf33b9fff8aa33a823422aa4e323137be07 According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323. DirMgr:: Remove Error::NoChange as redundant. 2022-05-25T12:58:37Z Nick Mathewson nickm@torproject.org 2022-05-25T12:58:37Z urn:sha1:0caa5bcba5c3be8aca2fb90331a830d1a22f5e22 Now that the relevant functions now report changed/not-changed status via a boolean out-parameter (see !527), there's no reason to have a separate NoChanged error case. Closes #484. Remove BootstrapAction::Impossible 2022-05-19T12:00:41Z Nick Mathewson nickm@torproject.org 2022-05-19T12:00:41Z urn:sha1:6aebb18e64f148d6f554ad1bd84e19b0128e121a It does nothing that Fatal does not. Suggested by @eta in review. DirMgr: Start refactoring error handling. 2022-05-17T13:52:44Z Nick Mathewson nickm@torproject.org 2022-05-17T13:46:50Z urn:sha1:6bacf3b303b4f94b0eaf4132c83225c8675e035c This commit adds a couple of new error types that we will soon want to distinguish, and a new way of classifying errors. These are not yet all used. On a blocking error, blame the appropriate directory cache 2022-05-16T16:49:49Z Nick Mathewson nickm@torproject.org 2022-05-16T16:22:34Z urn:sha1:d1af40e638053b36029a83712f1e4ab261fe6340 Fortunately, the only error type that we need to handle blocking errors with actually has a DirSource in it already. Delete tor_dirmgr::Error::BadNetworkConfig 2022-05-12T15:49:06Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T15:49:06Z urn:sha1:d847d49858d480dc24713e8edab418340733b97e This was anomalous, in that it contains &'static str, rather than a proper nested error (eg a config::ConfigError, maybe). But in fact it tursn out it is now not constructed. The last construction site was removed a long time ago in Use derive_builder for Authority and FallbackDir. tor-dirmgr/bootstrap.rs: error on older netdirs, add log line 2022-05-10T12:29:39Z eta tor@eta.st 2022-05-10T10:21:53Z urn:sha1:8347f8cb7e749d9413b68ddc1aa673b7f9e2d14b - We don't want to inadvertently replace our netdir with one that's actually older, so detect and error on this condition. - Also, print a debug line when we get a new netdir without enough guards. - (An unrelated TODO was also added.) Update tor-dirmgr to use fs-mistrust. 2022-05-09T18:40:29Z Nick Mathewson nickm@torproject.org 2022-05-03T17:08:18Z urn:sha1:20a85061b6c7c5a88b98497aabdf986cd6a462df Fix typos 2022-04-20T11:48:43Z Samanta Navarro ferivoz@riseup.net 2022-04-20T11:46:31Z urn:sha1:142e57b03a6ec3a051c0693273eedeb6241cfec2 Typos found with codespell. Treat expired/not-yet-valid directory objects as Errors. 2022-04-05T19:54:37Z Nick Mathewson nickm@torproject.org 2022-04-05T19:54:37Z urn:sha1:d05022dea4186b39647b077b0850e6c25f39dc41 Doing this will make us treat caches that send us these objects as not-working, and close circuits to them instead of trying over and over. The case where we add a document from the cache requires special handling: it isn't actually a error to find an expired document in our cache (unless the passage of time itself is erroneous, which is a debatable proposition at best). Fixes #431.