mirrors/arti.git/crates/tor-dirmgr/src/bootstrap.rs, branch arti-v1.0.1

fix clippy::unwrap_used and old TODO for msrv 1.56

2022-09-10T12:37:32Z

`TaskSchedule`: give error on `sleep*()` if last handle is dropped

2022-09-07T13:22:38Z

This fixes an busy-loop. When the last `TaskHandle` on a `TaskSchedule` is dropped, the schedule is permanently canceled: whatever operation it was scheduling should no longer be performed. But our code was broken: the `sleep()` and `sleep_until_wallclock()` functions don't verify whether the handles are dropped or not. This breakage caused an CPU-eating busy-loop in `sleep_until_wallclock`. With this patch, we now return a `Result<(), SleepError>` from these functions. Fixes #572.

tor-dirmgr: Remove opt_netdir entirely.

2022-07-26T09:41:38Z

Its existence tended to hide bugs, and was just asking for trouble.

Make display formats work with older derive_more.

2022-06-14T18:10:18Z

Do not update_progress on load if nothing happened.

2022-06-14T13:58:58Z

If there was no partial information, then calling update_progress will now report a stall in this case, which is not what we want.

DirMgr: Track errors, stalls, and resets as part of status.

2022-06-13T17:58:31Z

A "reset" happens whenever we have to start a download attempt over -- either because we ran out of retries, or we found something wrong with the consensus after fetching certificates. An "error" happens when we have a recoverable error from one or more directory sources. A "stall" happens whenever a round of downloads or cache loads leads to no change in the status. We don't yet use this as part of our status reporting.

Refactor our logic for distinguishing download attempts

2022-06-13T17:21:09Z

Previously we used the "if-modified-since" time associated with the consensus download, and/or the "valid-after" time in the consensus attempt, to put multiple attempts into sequence, and to tell one from another. But that approach was always a kludge, and will soon get more unreliable as the DirStatus logic gets a bit more complex. With this commit, we change separate download attempts to be identified with an AttemptId that increments whenever we decide to get a different directory from the one we have. IMO this new code is _much_ cleaner.

Refactor most DirStatus users to use DirProgress.

2022-06-13T16:22:04Z

This is all crate-internal APIs, fortunately.

DirMgr: Refactor bootstrap to use a TaskSchedule for sleeping.

2022-06-10T17:59:30Z

This change (not yet exposed as an API) will let the TorClient have a `TaskHandle` corresponding to the directory task, letting it make the directory task dormant as needed.

DirMgr:: Remove Error::NoChange as redundant.

2022-05-25T12:58:37Z

Now that the relevant functions now report changed/not-changed status via a boolean out-parameter (see !527), there's no reason to have a separate NoChanged error case. Closes #484.