mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-09-18T11:25:36Z 2023-09-18T11:25:36Z eta tor@eta.st 2023-08-22T15:52:28Z urn:sha1:a6fe895eb5c605e9c8de7ba871fc2114d65e098c This threads the country codes work through the rest of the codebase: - `tor-dirmgr` will now enable GeoIP with the embedded database when the `geoip` future is enabled - This can be extended later using the `DirMgrConfig` to allow specifying a custom database; this is not done here, though - `tor-circmgr`'s `SupportedCircUsage` and `TargetCircUsage` fields gain new `country_code` members to allow filtering circuits by country - These are `()` in builds where the `geoip` feature is not enabled -- doing it this way means we don't have to copy and paste huge swathes of code, since we can't use `#[cfg]` in patterns - `ExitPathBuilder` gains (hacked-in) support for choosing a relay with the correct country code - Due to the lack of conjuction, we just copy and paste a small bit, pending further refactoring - `StreamPrefs` now lets you specify a country code, letting embedders make use of the feature 2023-09-05T16:22:19Z Nick Mathewson nickm@torproject.org 2023-09-05T16:22:19Z urn:sha1:e251baa9a77415f3c605ff462a8ac0b3fa37660a These are: ``` hashx equix tor-async-utils tor-error tor-config tor-rtmock tor-llcrypto tor-bytes tor-hscrypto tor-hspow tor-cert tor-linkspec tor-cell tor-proto tor-netdoc tor-netdir tor-chanmgr tor-guardmgr tor-dirmgr tor-keymgr tor-hsclient tor-hsservice arti-client arti ``` 2023-09-05T16:20:01Z Nick Mathewson nickm@torproject.org 2023-09-05T16:20:01Z urn:sha1:6f5dfc71b86b1ce2ec664e97d6be507189443334 These are: ``` tor-dirclient tor-ptmgr ``` 2023-08-01T14:57:55Z Nick Mathewson nickm@torproject.org 2023-08-01T14:57:55Z urn:sha1:3acdf102c705314aec63679e97240bb7d981d1c8 These crates are at version 0.x.y, so we don't need to distinguish new-feature changes from other changes: ``` tor-basic-utils fs-mistrust tor-error tor-geoip tor-checkable tor-linkspec tor-netdoc tor-netdir tor-persist tor-ptmgr tor-hsservice ``` This crate has a breaking change, but only when the semver-breaking feature `experimental-api` is enabled: ``` tor-config ``` This crate is at version 1.x.y, but has no new public APIs, and therefore does not need a minor version bump: ``` arti ``` 2023-08-01T14:51:25Z Nick Mathewson nickm@torproject.org 2023-08-01T14:51:25Z urn:sha1:6f2ae5960393b64c1d7615d2d523e050d3bebe5a These crates had first-order breaking changes: ``` retry-error tor-keymgr tor-proto tor-hsclient tor-rtmock ``` Additionally, these broke because they re-exposed RetryError: ``` tor-circmgr ``` Additionally, these broke because they may re-expose something from tor-proto: ``` arti-client tor-chanmgr tor-dirclient tor-dirmgr tor-guardmgr ``` Additionally, these broke for other fiddly reasons: `tor-ptmgr` implements traits from tor-chanmgr, which has a breaking change above. `arti-hyper` exposes types from arti-client in its API. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. 2023-07-06T14:14:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-05T15:52:21Z urn:sha1:a4bb2a8b575baf5f8e77d2c6b14f74528fd1b7e9 This isn't used any more. 2023-06-30T12:42:21Z Nick Mathewson nickm@torproject.org 2023-06-30T12:42:21Z urn:sha1:de13a7319b7de5a336a70f128d1904954ed77f82 Done with the commands below. The following crates have had various changes, and should get a patchlevel bump. Since they are pre-1.0, we do not need to distinguish new APIs from other changes. ``` cargo set-version --bump patch -p arti-client cargo set-version --bump patch -p safelog cargo set-version --bump patch -p tor-bytes cargo set-version --bump patch -p tor-cert cargo set-version --bump patch -p tor-circmgr cargo set-version --bump patch -p tor-config cargo set-version --bump patch -p tor-consdiff cargo set-version --bump patch -p tor-dirclient cargo set-version --bump patch -p tor-dirmgr cargo set-version --bump patch -p tor-error cargo set-version --bump patch -p tor-hsservice cargo set-version --bump patch -p tor-linkspec cargo set-version --bump patch -p tor-llcrypto cargo set-version --bump patch -p tor-netdir cargo set-version --bump patch -p tor-netdoc cargo set-version --bump patch -p tor-proto cargo set-version --bump patch -p tor-rpcbase cargo set-version --bump patch -p tor-socksproto ``` This crate has new features, but no new non-experimental Rust APIs. So even though it is post-1.0, it gets a patchlevel bump. ``` cargo set-version --bump patch -p arti ``` 2023-06-26T13:30:54Z Nick Mathewson nickm@torproject.org 2023-06-26T13:30:54Z urn:sha1:0bffdf23a4c9f185b88eb426681bf9ca5f12610f The breaking changes here do not seem to affect us. 2023-06-21T13:13:55Z Nick Mathewson nickm@torproject.org 2023-06-21T13:13:55Z urn:sha1:16a07a8f63117b798ef909ac630e5152fc95f6dc