mirrors/arti.git/crates/tor-dirclient/src/response.rs, branch arti-1.2.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-1.2.12024-03-13T16:30:53ZRun maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cPreserve HTTP status text in dirclient errors.2023-11-29T20:14:36ZNick Mathewsonnickm@torproject.org2023-11-29T20:09:48Zurn:sha1:e38219a1688f76288c61e42ee56cbd646a1c76c8
The HTTP status text is often useful for diagnosing errors. Tor
directory and hsdir caches frequently put useful messages there,
especially when rejecting an uploaded document.
Inspired by #1142.
tor-dirclient: Mark `DirResponse` as `#[must_use]`.2023-10-03T11:07:20ZGabriela Moldovangabi@torproject.org2023-10-02T17:47:51Zurn:sha1:61c5a22017b4bd2a581090523088ce6af0bd7db1
Not checking whether the response is successful can have unintended
consequences.
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
tor-dirclient: Replace OwnedChanTarget with LoggedChanTarget in SourceInfo2022-11-23T18:28:38ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-23T15:13:33Zurn:sha1:ef5a58e1585b478e26fd7c18b61cdf7b1e069e93
SourceInfo primarily appears in errors, here and in (indirectly)
tor-dirmgr.
This
1. Makes the errors smaller
2. Redacts (currently, scrubs) the chantarget when safe logging is enabled
This commit therefore deals with both tor-dirmgr and tor-dirclient
errors, from the pov of error information that should become sensitive
as part of bridge support.
The error pyaloads directly in tor_dirmgr/src/err.rs don't seem to
contain anything in that category.
tor-dirclient: Response: Provide into_output_string2022-11-03T11:37:05ZIan Jacksonijackson@chiark.greenend.org.uk2022-10-31T18:28:50Zurn:sha1:0fb535ba28f6fd10d62ff4fb3d89a9f5da8160d3
This is the missing one of the full set. It turns out that I wanted
this rather than the non-consuming output_string.
tor-dirclient::DirResponse: provide output_string2022-10-25T19:12:56ZIan Jacksonijackson@chiark.greenend.org.uk2022-10-21T16:10:25Zurn:sha1:b68f7af79bf438aedfeff775183d89c0d1b45699
This gives callers a nice error type with source and everything.
tor-dirclient: Provide fallible DirResponse::output and into_output2022-10-20T16:24:53ZIan Jacksonijackson@chiark.greenend.org.uk2022-10-19T11:20:32Zurn:sha1:7b2a0fbcb1ea8a3bed0277353728c25309879913