mirrors/arti.git/crates/tor-dirclient/src/lib.rs, branch arti-v1.1.6 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.6 2023-06-21T11:15:41Z lints: Run maint/add_warning to actually apply new lints 2023-06-21T11:15:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-21T10:29:46Z urn:sha1:161b9844dae0aaa2e63bbc77c512d061be6bb390 tor-dirclient: De-genericise internal fn retire_circ 2023-01-30T18:00:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:00:53Z urn:sha1:0e6be61db61ba2d76f575a91d57ece4f8b3bb04d Requring `Display` is wrong here, because if this is actually an Error, Display would be wrong because it doesn't display causes. As it happens, the `error` parameter is only ever `&str`. Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. Disable clippy::unlinlined-format-args 2023-01-27T13:27:47Z Nick Mathewson nickm@torproject.org 2023-01-27T12:49:39Z urn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2 This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. Run add_warnings. 2022-11-03T15:06:02Z Nick Mathewson nickm@torproject.org 2022-11-03T15:06:02Z urn:sha1:932fe48eaf83f456eefd59475b4486d59966dec3 tor-dirclient: Promise that download only gives RequestFailed 2022-10-25T19:12:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-21T16:11:06Z urn:sha1:0b046ad4fba3ed8dba8d06d66dd742c1719ab18b tor-dirclient: Make RequestFailed its own error type (rustfmt) 2022-10-20T16:24:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-19T15:17:29Z urn:sha1:e8d662ed7c25f499fc7d557c3a6ebf11176ce365 Split off to assist review. tor-dirclient: Make RequestFailed its own error type 2022-10-20T16:24:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-19T11:14:12Z urn:sha1:d9375b2b8d60c43023b6a41c0d2429ea6efa72c6 We're going to have functions on Response that fail by returning only one of these. Sadly this diff is quite noisy. tor-dirclient Response: Rename output methods 2022-10-20T16:24:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-19T10:57:04Z urn:sha1:3b1af058519a1be1ea2ce893115f2664cb2d8a08 These don't check errors and are therefore quite hazardous. I'm going to introduce a more cooked version in a moment.