mirrors/arti.git/crates/tor-dirclient/src/err.rs, branch main

tor-dirclient: Only fail on empty GET responses

2026-03-04T15:41:19Z

This commit fixes the previous check to only fail on empty GET responses. For this, it introduces a `method` field into `DirResponse`, which is required to determine the method there. Doing this is reasonable for an HTTP client, as responses have different meanings depending on the request method used.

tor-dirclient: Disallow empty successful responses

2026-03-04T15:41:19Z

This commit disallows empty responses with a status code 200. From a pure HTTP level, this is totally valid, but it does not make any sense in the context of the Tor directory protocol, where an empty response only makes sense with a 404. The motivation for this is that a work-in-progress tor_dirclient::send_request wrapper for tor-dirserver passes the response into the parse2 multiple function which returns a Vec. Interfacing code would then always have to check for an empty length and do respective error handling, which should already fail at an earlier level (tor-dirclient) instead.

tor-dirclient: Document retriability of failures

2026-02-05T14:56:28Z

This commit documents the retriability of `RequestFailedError`, following an IRC conversation with nickm.

tor-dirclient: Improve upon error logging

2025-12-10T11:20:01Z

This commit improves upon the error logging of the `tor-dirclient` crate in order to not just log the location/source of an error but also the actual reason of an error.

dirclient: Use the new Tunnel interface

2025-08-05T18:23:02Z

This entirely removes the requirement on ClientCirc. Signed-off-by: David Goulet

dirclient: treat excessive incoming cells as suspicious.

2025-07-10T13:41:48Z

hs*: Define some HsDesc errors as _suspicious_.

2025-07-10T13:41:48Z

These errors are suspicious as hsdir inflation attacks, in the context of prop360.

dirclient: New error type for too-long headers.

2025-07-10T13:41:48Z

(This was previously called a parse error, which isn't right.)

Fix typos

2024-09-03T08:09:02Z

Preserve HTTP status text in dirclient errors.

2023-11-29T20:14:36Z

The HTTP status text is often useful for diagnosing errors. Tor directory and hsdir caches frequently put useful messages there, especially when rejecting an uploaded document. Inspired by #1142.