mirrors/arti.git/crates/tor-consdiff/src/err.rs, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-03-25T15:17:30Z tor-consdiff: Enforce Unix line endings 2026-03-25T15:17:30Z Clara Engler cve@cve.cx 2026-03-23T14:09:24Z urn:sha1:05bbdf523c1d72b10a4e2f4adb47279b9884634e This commit changes the consdiff generation to enforce Unix line endings and reject all other ones, including Windows line endings as well as no line endings. In other words, it checks for `\n` while forbidding `\r\n`. It also renames the relevant error variant to reflect this change better. tor-consdiff: Use named variants for lno errors 2026-03-25T15:17:29Z Clara Engler cve@cve.cx 2026-03-18T10:28:42Z urn:sha1:d3dacd11794581fc752b7ea53cb82fd14fc41a87 This commit changes the error variants that contain a line number to a named variant with a field `lno: usize` to make it semantically clear, that it is a line number. tor-consdiff: Remove manual line splits 2026-03-25T15:17:29Z Clara Engler cve@cve.cx 2026-03-12T16:17:31Z urn:sha1:1220c281e70d148f8c0dcf2f0aa5f0707c439058 This commit removes all manual line splits in the consdiff generation. Instead, it now simply uses the primitives offered by imara-diff to access the lines in the input itself. Meanwhile, it also adds a check for missing newlines/assertions that all lines are actually terminated by \n. tor-consdiff: Return error for dotline 2026-03-25T15:17:29Z Clara Engler cve@cve.cx 2026-03-09T12:33:28Z urn:sha1:61276a1eb5ad5f628b547c38ce1bf4cd459fe7dd This commit adds a check that prevents gen_cons_diff from computing a diff with a single dot line. tor-consdiff: Failed applies are a Bug 2026-03-25T15:17:29Z Clara Engler cve@cve.cx 2026-03-09T10:23:32Z urn:sha1:caba6db293f0bafa51da1bf595eeadcdca7b80fe Mark a failed apply from a consensus diff we generate as a bug as this should not happen. We must obviously always accept the consensus diffs we produce. tor-consdiff: Add consdiff generation algorithm 2026-03-25T15:14:49Z Clara Engler cve@cve.cx 2026-02-24T09:54:27Z urn:sha1:44d44537bfba876b40512e2cdf877e93dea086fa This commit implements support for the consensus diff generation. Unlike CTor, it does not use its own custom algorithm but rather uses an implementation of Myers' algorithm from the `imara-diff` crate, which is pretty performant and comparable to size and run time to CTor, while being much simpler in the interfacing code. Move all crates into a `crates` subdirectory. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.