mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.2 2023-01-27T13:28:02Z 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. 2022-12-06T15:15:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-06T15:11:39Z urn:sha1:ba338bdf371250210474346bf0ac492d3bc70672 This is the new upstream version (published by me, recently). It has the same MSRV and one breaking change: The caller who specifies a home dir function for substituting into strings, must now supply a string, not Path. Previously shellexpand would allow the caller to supply non-unicode data, and then simply not substitute it. That was an infelicity in the shellexpand API. Now this infelicity is pushed into our code. The overall behaviour of Arti hasn't changed as a result. And it seems reasonable to me. shellexpand 3.x also has a module for expanding Paths instead, in response to requests for this filed as upstream tickets. We *could* use that but I am not sanguine about that approach: the Pathness would spread throughout much of our config and file handling code. I think we should at the very least postpone trying to work with invalid-unicode-paths as long as we can. 2022-12-06T15:11:58Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-06T15:11:26Z urn:sha1:010ffd6ea6c517379a8913c953932986d68a32a4 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. 2022-10-11T10:22:49Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T10:22:49Z urn:sha1:d6b85b27c4e15a5e8c1bb6b13b3d978f97977cfd 2022-10-07T13:03:00Z Nick Mathewson nickm@torproject.org 2022-10-07T12:35:57Z urn:sha1:e005d38edb886ed21f9f8c234c94432d76db3417 `${PROGRAM_DIR}` expands to the equivalent of `std::env::current_exe().parent()`, with appropriate unwrapping and conversions. It is expected to be useful for finding the locations of pluggable transports in some kinds of bundles. Closes #586. 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. 2022-06-22T12:36:13Z Nick Mathewson nickm@torproject.org 2022-06-22T12:36:13Z urn:sha1:c39631af2770ef44d40f172cf24dd86f813cbfda 2022-05-27T17:14:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-27T17:14:03Z urn:sha1:35e3841e4c18e510a00931c30048ae022e4eaf13 This was done because Nightly Rust complained about these, despite them all being in tests. That is now fixed upstream: https://github.com/rust-lang/rust-clippy/issues/8758 https://github.com/rust-lang/rust-clippy/pull/8838 This reverts commit 9d26a91886990b08dc5b6033c290d417489c61fc. 2022-05-20T14:34:32Z Nick Mathewson nickm@torproject.org 2022-05-20T14:34:32Z urn:sha1:9d26a91886990b08dc5b6033c290d417489c61fc This should satisfy our CI and turn it green again.