mirrors/arti.git/crates/tor-config/src/misc.rs, branch arti-1.2.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-1.2.1 2024-03-13T16:30:53Z Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c educe: Use std's default for two structs 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:08:20Z urn:sha1:7eafea9d0b7bb5b1ccc2980df1c94defdd04a954 Reviewing uses of `#[educe(default)]`, I came across these two places where it was applied to a non-generic struct without any special attributes on fields. std's derive will do just as well here. educe: Use std's default for enums where default variant is unit 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:07:42Z urn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. Test for Listen Display 2023-09-25T21:10:02Z Jani Monoses jani.monoses@gmail.com 2023-09-25T21:10:02Z urn:sha1:fd128445c22db9270959bb3b7e5207da3151ee25 Do not writelns in Display, undo localhost_port_legacy changes. 2023-09-25T20:39:50Z Jani Monoses jani.monoses@gmail.com 2023-09-25T20:39:50Z urn:sha1:365ad8014ebdc9a6b09a4cd0e9275771e6da7fb7 arti, tor-config: Allow listening on generic addresses for SOCKS and DNS. 2023-09-22T16:19:40Z Jani Monoses jani.monoses@gmail.com 2023-09-20T07:33:04Z urn:sha1:d7f5a2b024226c8dbff5b2a01ad1a6c8615ee33a tor-config: Listen: Clarify localhost_port_legacy 2023-09-12T15:08:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-12T15:08:17Z urn:sha1:a7dc6baff64083897e4c44403b6f78b260ef19d9 The previous phrasing was ambiguous and set us up for bugs, see https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1582#note_2942240 tor-config: Listen: Fix a typo 2023-09-12T15:07:50Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-12T15:07:50Z urn:sha1:89252b4464b3dbe2e087f1be3a841745fda07b64 Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac tor-config: Remove unused ItemOrBool helper. 2023-07-13T11:30:07Z Gabriela Moldovan gabi@torproject.org 2023-07-12T18:10:11Z urn:sha1:5b97b0b2ce31b3dbe1ab9cf0d33109457d1aea47 `ItemOrBool` is currently not used anywhere (it was previously used by the keymgr config).