mirrors/arti.git/crates/tor-config/src/load.rs, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-08-07T15:28:36ZSwitch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
tor-config: fix `clippy::double_ended_iterator_last`2025-04-03T17:32:58ZSteven Engleropara@torproject.org2025-04-03T17:17:06Zurn:sha1:ec53c9eaa49e65f9c07c055518a1a543e868f8c8
```text
warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
--> crates/tor-config/src/load.rs:606:18
|
606 | .last()
| ^^^^^^ help: try: `next_back()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
note: the lint level is defined here
--> crates/tor-config/src/lib.rs:9:9
|
9 | #![warn(clippy::all)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::double_ended_iterator_last)]` implied by `#[warn(clippy::all)]`
```
Switch to figment 1.0.18 and extract_lossy2024-04-22T17:17:49ZNick Mathewsonnickm@torproject.org2024-04-22T11:43:25Zurn:sha1:d028024c737e23b72acdab6f6f4d8cf368a5df8f
The new (dubiously named) `Figment::extract_lossy` method
can treat decode numbers from strings, and booleans from numbers or
strings. This makes the behavior compatible with config-rs, and
should (I hope) finally allow us to migrate.
Convert tor-config to use figment.2024-04-22T17:17:49ZNick Mathewsonnickm@torproject.org2024-02-15T17:12:30Zurn:sha1:20d342db1a5fe976d26c709afa9d6b3859d4df28
There are probably ways to make this a bit more elegant, but at
least the tests still pass.
Merge branch 'encapsulate_config_rs' into 'main'2024-03-13T18:52:39ZNick Mathewsonnickm@torproject.org2024-03-13T18:52:39Zurn:sha1:6b120ec2117b8b0dfb5f0daa1746ec532cf3ad3a
Encapsulate usage of config-rs inside tor-config.
See merge request tpo/core/arti!2040Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320ctor-config: Update documentation to not refer to config crate.2024-03-13T13:48:35ZNick Mathewsonnickm@torproject.org2024-02-15T16:04:40Zurn:sha1:54863b653dd1e4910e288d44c74e0a21a8b58596config: Remove From impls from config::ConfigError2024-03-13T13:48:35ZNick Mathewsonnickm@torproject.org2024-02-15T15:59:32Zurn:sha1:1e002b6472e17b57f9a750d0aa2fbbb7855a4565
These are another case of exposing the config crate.
tor-config: Put config::Config inside a wrapper type.2024-03-13T13:48:35ZNick Mathewsonnickm@torproject.org2024-02-15T15:48:48Zurn:sha1:6e06a26e663cff13daae2cce480a7790bb9a1f0a
This will let us replace Config with something better.
Use ConfigurationSource::Verbatim in our tests.2024-03-13T13:38:22ZNick Mathewsonnickm@torproject.org2024-02-15T15:32:59Zurn:sha1:b529bb0a4dcabfae10a907fbed9101b9715fb559