mirrors/arti.git/crates/tor-config/src/list_builder.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
config: Update doctests to use Deftly, and to pass2026-05-27T12:05:52ZNick Mathewsonnickm@torproject.org2026-05-19T14:44:06Zurn:sha1:8d62f53b0a8f676ece49360184ab094d8dc0edb5
Some of the tests used derive(Builder), which is not current
practice for our configuration.
Additionally, they didn't implement the requisite ConfigBuilder
logic to pass with the other changes in this branch.
config: Add a method to fill in a builder with unset defaults2026-05-27T12:05:52ZNick Mathewsonnickm@torproject.org2026-05-18T14:13:34Zurn:sha1:f1df3d1c8d83fd63d484cccf0bf45534f0369761
This new method modifies a builder by replacing any unset values
that have a default with that default. We're using this method
so that we can re-serialize a builder into a `ConfigurationTree`
with all of its default values included.
In all cases, `b.apply_defaults()?; b.build()` should produce
the same output as `b.build()`.
The interesting parts of this commit are in tor_config::load
and tor_config::derive. The rest of this commit just adds
`apply_defaults` to other builders that _aren't_ made with
`derive_deftly(TorConfig)`.
config: Implement Builder for ListBuilders and MapBuilders.2026-05-27T12:05:52ZNick Mathewsonnickm@torproject.org2026-05-18T12:50:52Zurn:sha1:3f349864d55760a57a47db3cc326be4cc9c90383
This isn't strictly necessary, but it helps for consistency.
tor_config: Make ListBuilders implement ExtendBuilder.2025-12-09T16:32:14ZNick Mathewsonnickm@torproject.org2025-12-01T15:33:49Zurn:sha1:6aa3355b7884112cb2ca0de985aed49bd5b684b6tor-config: missing #[allow(dead_code)] in derive_list_builder_helper2025-12-09T16:32:13ZNick Mathewsonnickm@torproject.org2025-11-29T02:54:59Zurn:sha1:742c0e08a479e2cdc7a6ffe0e089e3b3da80a1a0tor-config: missing $crate in derive_list_builder_helper2025-12-09T16:32:13ZNick Mathewsonnickm@torproject.org2025-11-29T02:54:16Zurn:sha1:6f6188b22d0ecd3162b2b247f7d2321de871282ctor-config: obviate need for Educe in derive_list_builder_helper2025-12-09T16:32:13ZNick Mathewsonnickm@torproject.org2025-11-29T02:43:55Zurn:sha1:2e712a8c622e15debd294717caf82e920fdd81bc
We were only using it for Default, and it is easier to implement
Default by hand than it is to keep this particular layer in our
leaning tower of macros.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.