mirrors/arti.git/crates/tor-config/src/lib.rs, branch arti-v1.0.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.0.02022-08-25T19:04:52ZImprove error from bad escapes in a toml config.2022-08-25T19:04:52ZNick Mathewsonnickm@torproject.org2022-08-25T17:03:20Zurn:sha1:88fa24d029f14ab7e316506e44f7602ac86d12fd
Whereas previously we would say:
```
target/debug/arti: error: invalid escape character in string: `Z` at line 9 column 14 in ../../.config/arti/arti.toml
```
we now say:
```
target/debug/arti: error: invalid escape character in string: `Z` at line 9 column 14 in ../../.config/arti/arti.toml (If you wanted to include a literal \ character, you need to escape it by writing two in a row: \\)
```
The implementation is a bit of a hack, I'm afraid, but I don't think
it's all that bad.
Closes #549.
tor-config: Provide resolve_alternative_specs2022-08-25T17:41:28ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-24T11:08:15Zurn:sha1:846fe3d5207a86e3c73003288b0f1bdbb442e9fbtor-config: Introduce ResolutionResults2022-08-25T17:41:03ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-23T17:51:23Zurn:sha1:33358379f4bbbda3f4fd20bd5a413f3003e959cf
This will allow us to handle new kinds of warnigns etc.
tor-config: Replace dir detection with ConfigurationSource enum2022-08-25T14:58:29ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-24T17:56:27Zurn:sha1:9c00ec7da432a6ecd434fcb5227f50fc349c7162
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/682#note_2830860
And subsequent IRC discussion.
Having done the work as per review comments, I don't much like the
result. It's quite un-ergonomiuc. If we can't have fs autodetection,
I think syntactic autodetection within sources.rs would be nearly as
nice.
However, I seem to be outvoted. At least the externally visible
functionality (of an arti binary, say) is reasonably ergonomic.
enable doc_auto_cfg feature on every crate when documenting for docs.rs2022-08-24T16:22:41Ztrinity-1686atrinity@deuxfleurs.fr2022-08-17T19:13:13Zurn:sha1:7f939fa4804b3c934343141b79e8e2ded5fe0b0dtor-config: resolve_option_general: Add TODO about example2022-08-23T13:20:49ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-23T13:20:49Zurn:sha1:0c747b8069f6a3c316751dfb575a0f2b8787a01fFix syntax in doc comment.2022-08-23T12:59:41ZNick Mathewsonnickm@torproject.org2022-08-23T12:59:41Zurn:sha1:32c14d37bfa246be84f419d11cc06c5dd327af0dtor-config: Provide resolve_option_general, for T: !Default etc.2022-08-22T15:26:38ZIan Jacksonijackson@chiark.greenend.org.uk2022-06-22T13:38:33Zurn:sha1:457c17adb078455ef5fdc8ed429d0d9d7d89754c
At one point in this MR I thought I was going to want this for
arti::cfg::ListenConfig (which we don't want to be Default).
In fact ListenConfig is being handled specially, but having written
this function it seemed sensible to keep it. Since resolve_option
becomes a wrapper for it, the existing tests exercise it.
tor-config: Introduce PaddingLevel2022-08-16T17:38:53ZIan Jacksonijackson@chiark.greenend.org.uk2022-07-27T15:01:59Zurn:sha1:2fbc196f8e85d5bebc1178c2f4a6f460c8bceb5d
This will be used for controlling channel padding, for now.
Run maint/add_warning crates/*/src/{lib,main}.rs2022-06-23T18:15:42ZIan Jacksonijackson@chiark.greenend.org.uk2022-06-23T18:15:29Zurn:sha1:589c6e52bb49ccfe6c0ad9d18d6b994978e46c6c
Update all lint blocks