mirrors/arti.git/crates/tor-config/src/file_watcher.rs, branch arti-v1.3.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.1 2024-10-16T15:59:27Z tor-config: Document the limitations of the FileWatcher. 2024-10-16T15:59:27Z Gabriela Moldovan gabi@torproject.org 2024-10-16T15:38:00Z urn:sha1:960ff90c2e595928389b2c8feaf2e052d7dc9f58 tor-config: Compare the file contents when testing. 2024-10-16T15:59:22Z Gabriela Moldovan gabi@torproject.org 2024-10-16T14:22:05Z urn:sha1:c35579bac717f9126d8942fca6f0e9b8ca9bfbdb When testing, compare the contents of the files too, not just their mtime Otherwise, because the polling backend detects changes based on mtime, if the test creates/writes files too fast, it will fail to notice changes (this can happen, for example, on a tmpfs). tor-config: Configure the polling interval. 2024-10-16T15:59:22Z Gabriela Moldovan gabi@torproject.org 2024-10-16T13:12:53Z urn:sha1:446ebd924ff8cb8ca6786a9cfc76469c5e45d5ac The default is 30s, which feels a bit too long. Also, when testing, we use a much shorter interval. This is meant to be a temporary solution, so we hard-code the interval rather than make it configurable. tor-config: Use a polling watcher on non-windows platforms that don't have inotify. 2024-10-16T15:59:07Z Gabriela Moldovan gabi@torproject.org 2024-10-16T12:53:04Z urn:sha1:f397797958c8d2e373a9dbae7e26093780712c46 On windows and platforms that support inotify (i.e. linux and android), we continue using the recommended watcher. On platforms that use kqueue, we switch to a polling watcher to work around a [notify bug] that manifests when using a non-recursive watcher to watch a directory. This commit is best reviewed with `git diff --ignore-all-space`. Closes #1644 [notify bug]: https://github.com/notify-rs/notify/issues/644 tor-config: Add a type alias for the underlying watcher (fmt). 2024-10-16T15:38:15Z Gabriela Moldovan gabi@torproject.org 2024-10-16T14:57:32Z urn:sha1:3e0ed0059285e4060966fa450b681c8f7ce87831 tor-config: Add a type alias for the underlying watcher. 2024-10-16T15:38:15Z Gabriela Moldovan gabi@torproject.org 2024-10-16T12:46:48Z urn:sha1:4b23bbfa2593b3d245e405db9b23efe264a6ebf7 This type will soon become platform-dependent, so I am preemptively adding a type alias. tor-config: Improve FileWatcher documentation. 2024-08-28T11:52:15Z Gabriela Moldovan gabi@torproject.org 2024-08-28T11:33:25Z urn:sha1:9e3294daafb7faebc6bc2396e98167ed6a696c57 tor-config: Add tests for FileWatcher::watch_path. 2024-08-28T11:08:28Z Gabriela Moldovan gabi@torproject.org 2024-08-28T10:49:07Z urn:sha1:46841828b4aa6da666c22eb4ab1eefcda6cedb60 tor-config: Make a test helper take a reference to TempTestDir. 2024-08-28T10:41:17Z Gabriela Moldovan gabi@torproject.org 2024-08-28T10:41:17Z urn:sha1:97dc9f859492571109130b8039bbcab214312349 tor-config: Rename watch_file to watch_path. 2024-08-27T13:35:30Z Gabriela Moldovan gabi@torproject.org 2024-08-27T11:30:19Z urn:sha1:5619aa0ed22a2421defa53189564baea24a0bf16 `FileWatcher::watch_file` can be used with arbitrary paths.