mirrors/arti.git/crates/tor-config/src/derive.rs, branch main

tor-config: derive.rs: use beta_deftly $impl feature

2026-06-11T10:37:21Z

assert_not_impl: Promote to tor-basic-utils

2026-06-10T14:42:10Z

I want this in tor-netdoc (which doesn't use tor-config and probably shouldn't). Almost entirely code motion. Review with --color-moved.

assert_not_impl: Change example to use Cell

2026-06-10T14:42:10Z

I want to mvoe this to tor-basic-utils, so it can't use tor-config in its example. Also, Cell is just a nicer example. (The rule identifier was already wrong.)

assert_not_impl: Introduce some `use`s

2026-06-10T14:42:10Z

IMO this makes the example clearer. It will also make moving this macro to tor-basic-utils less noisy.

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

Apply 3 suggestion(s) to 2 file(s)

2026-05-27T12:05:52Z

Co-authored-by: gabi-250

config: Add a dd(TorConfig) attribute to override apply_defaults().

2026-05-27T12:05:52Z

config: Add a method to fill in a builder with unset defaults

2026-05-27T12:05:52Z

This new method modifies a builder by replacing any unset values that have a default with that default. We're using this method so that we can re-serialize a builder into a `ConfigurationTree` with all of its default values included. In all cases, `b.apply_defaults()?; b.build()` should produce the same output as `b.build()`. The interesting parts of this commit are in tor_config::load and tor_config::derive. The rest of this commit just adds `apply_defaults` to other builders that _aren't_ made with `derive_deftly(TorConfig)`.

dd(TorConfig): change the order of default vs magic

2026-05-27T12:05:51Z

This affects the automatic builder code made by our derive_deftly macro. It is only relevant (for now) in the case of the `NonZero<>` types and their special handling. Previously, when a builder contained Option, and we wanted to generate a configuration holding T, we would _first_ apply a transformation from Option to Option and _second_ unwrap the result or apply a default. Now, we _first_ convert from Option to U by applying a default, and only _then_ perform any necessary conversion from U and T. This is only relevant in the case where U and T are different. It simplifies writing the defaults for `NonZero` options, and will significantly simplify the logic for setting builder defaults.

tor-config::derive: use cfg(true) and cfg(false)

2026-05-07T12:08:01Z

Rust 1.88 added these, so we no longer have to use `any()` for false and `all()` for true.