mirrors/arti.git/crates/tor-circmgr/src, branch arti-v1.1.7 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.7 2023-07-18T12:10:03Z tor-circmgr: impl AsRef<dyn std::error::Error> for some error types 2023-07-18T12:10:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-18T11:12:01Z urn:sha1:dd5ceed79144f1750cd63fcfee27885e70b1b015 We're about to want this. Merge branch 'clippy-allow' into 'main' 2023-07-11T09:37:42Z Ian Jackson iwj@torproject.org 2023-07-11T09:37:42Z urn:sha1:3acc2af4f3411588f80669ae1980679dd260b119 clippy: Allow some of our existing code patterns See merge request tpo/core/arti!1396 rng ranges: Use gen_range_infallible() for Duration::ZERO..=T 2023-07-10T15:08:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T13:19:55Z urn:sha1:b151237a7f8651ed8694748832af05786a7eccfd rng ranges: Use gen_range_checked().unwrap() in test case 2023-07-10T15:07:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T13:18:32Z urn:sha1:8ae759ef9578d065a9021a2670bbb78c5bfe46b7 Ideally we would be allowed to use vanilla gen_range() here, but there doesn't seem to be a way to allow a specific clippy-forbidden method using #[allow] and we probably don't want to make a blanket allow. rng ranges: Use gen_range_checked().expect() in obvious cases (fmt) 2023-07-10T15:07:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T15:17:32Z urn:sha1:332285015f7d8c4a4e4edd260425bb06f7399e75 rng ranges: Use gen_range_checked().expect() in obvious cases 2023-07-10T15:07:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T12:47:04Z urn:sha1:5e10805ede1cc1452d37fa3fb8841127f3060a88 In each of these, it is locally obvious that the range is nonempty. Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Merge branch 'inclusive' into 'main' 2023-07-07T17:07:58Z Nick Mathewson nickm@torproject.org 2023-07-07T17:07:58Z urn:sha1:7d1c8dfde0f2b9c545fdff78885856fdc8a101f0 rng ranges: Use inclusive Duration ranges in several places See merge request tpo/core/arti!1385 rng ranges: Use inclusive Duration ranges in several places 2023-07-07T15:13:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T13:10:23Z urn:sha1:bcc3e6fef8b863fa6a863aae2d6234fba7fb99f6 Many of these call sites would panic if, somehow, the upper bound was zero. In most cases it is very complicated to see if whether this could happen. However, there is a better answer: Durations are (conceptually) dense, so picking the closed set (which includes its boundary) rather than the open one (which doesn't) will make little practical difference. So change four call sites to use `..=` instead of just `..`. Merge branch 'report-bugs-v2' into 'main' 2023-07-07T13:49:59Z Nick Mathewson nickm@torproject.org 2023-07-07T13:49:59Z urn:sha1:70f0fe634fedb359028e465d95083e23d3b3821b Optional tracing support in tor-error for error reporting See merge request tpo/core/arti!1379