mirrors/arti.git/crates/tor-circmgr/src/timeouts.rs, branch arti-v2.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.1 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. circmgr: Document caveats about BuildCircuit estimator 2026-05-07T14:17:39Z Nick Mathewson nickm@torproject.org 2026-04-30T14:22:59Z urn:sha1:ce1b8826fcda4c3ed2e4c5c77e8e184dc4bc80da There's no reason that the next person should have to rediscover these caveats. circmgr: Modernize and correct saturating_mul_f64 2026-05-07T14:17:23Z Nick Mathewson nickm@torproject.org 2026-04-30T13:52:53Z urn:sha1:35f7dfe5e76f6620118576ec42a13920fe144ac5 Duration::try_from_secs_f64 has existed since Rust 1.66, so we can use it now. It seems wrong to treat "infinity" and "negative infinity" as "one second", so make them actually saturating. Additionally, document behavior for infinity and negative infinity, and document that the NaN behavior isn't documented. (And secretly NaN behavior return a number on the same order of magnitude as the input.) circmgr: Avoid half-steps in our timeout_scale calculation 2026-05-07T12:33:03Z Nick Mathewson nickm@torproject.org 2026-04-30T13:37:02Z urn:sha1:1a11a4ff43cece6edaaa2394d5e4a3c7b0db078d This strategy is safe because (outside of our tests) we never look at the actual values of timeout_scale, but only at their ratios. circmgr, hsclient: Introduce and use a OneWay timeout estimator. 2026-05-07T12:33:03Z Nick Mathewson nickm@torproject.org 2026-04-30T13:28:45Z urn:sha1:9d3c0bb0eff93e902853694d929d5aade8cdd49f Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 circmgr: Now that Action is public, clean it up a little. 2023-06-22T17:53:14Z Nick Mathewson nickm@torproject.org 2023-06-21T16:00:09Z urn:sha1:dcb3b06a95738d86b137d40562bb71053ae05579