mirrors/arti.git/crates/tor-circmgr/src/preemptive.rs, branch arti-v0.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.02022-05-04T12:50:10ZChange builder list API2022-05-04T12:50:10ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-04T12:32:35Zurn:sha1:4bca91271558d950092fb1ac51c1316655d293cb
The new API is (roughly) as discussed in
https://gitlab.torproject.org/tpo/core/arti/-/issues/451
This is quite a large commit and it is not convenient to split it up.
It contains the following changes:
* Redo the list builder and accessor macros implemnetation,
including docs and tests.
* Change uses of define_list_config_builder. In each case:
- Move the docs about the default value to the containing field.
- Remove the other docs (which were just recapitulations, and
are now not needed since the ListBuilder is no longer public).
- Rewmove or replace `pub` in the define_list_builder_helper call,
so that the builder is no longer public.
- Change the main macro call site to use define_list_builder_helper.
- Add a call to define_list_builder_accessors.
* Make the module `list_builder` pub so that we have somewhere to
put the overview documentation.
* Consequential changes:
- Change `outer.inner().replace(X)` to `outer.set_inner(X)`
- Consequential changes to imports (`use` statements).
Rename ThingListBuilder::replace (from set)2022-04-25T17:15:25ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T15:55:21Zurn:sha1:1f215da1a32af7e7bbac7e8314858659c6d59c4e
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/471#note_2798024
Introduce PredictedPortsListBuilder2022-04-25T16:05:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T13:33:03Zurn:sha1:24518675dbd2e649b554ecc0117ea62ede11b292
This means that `NetworkConfig::initial_predicted_ports` is now like
the other list-like things, returning `&mut list_builder` with the same
`set()` and `append()` methods.
move isolation in separate module2022-03-24T18:43:54Ztrinity-1686atrinity@deuxfleurs.fr2022-03-24T18:43:54Zurn:sha1:8dc6e958aa305236054a43c0db74dda9176e0702add trait to help test isolation related code2022-03-16T18:24:23Ztrinity-1686atrinity@deuxfleurs.fr2022-03-15T23:30:41Zurn:sha1:4eb90b72c04b34fb54baa197b1bf85734a769f64fix existing tests2022-03-16T18:23:21Ztrinity-1686atrinity@deuxfleurs.fr2022-03-12T09:32:48Zurn:sha1:234291f666c062a364685fda24aa46d59c6caf38preemptive.rs: Use Instant::checked_add instead of raw subtraction2021-12-20T19:27:55Zetator@eta.st2021-12-20T19:27:55Zurn:sha1:091065454e86b81052689bd2ba704045f86694ad
The implementations of `Add` / `Sub` (et al.) on `std::time::Instant`
can panic if the underlying OS structure can't represent the result
(like arti#266). Use Instant::checked_add and print a warning instead,
to prevent panicking.
Also, we now add instead of subtracting; I suspect it's reasonable that
you might not be able to go backward past the first `Instant` created on
some platforms, but going *forward* should probably work?
Minor circuit predictor tweaks and comments.2021-12-07T21:48:09ZNick Mathewsonnickm@torproject.org2021-12-07T21:48:09Zurn:sha1:cac4ce759e70700a13ad75cf2eb1c3e2234cf4c1
Most notably, make min_exit_circs_for_port actually get used.
Also add a couple of comments.
Make preemptive circuits reconfigurable.2021-12-07T21:42:58ZNick Mathewsonnickm@torproject.org2021-12-07T21:42:58Zurn:sha1:0f8d6207578e6fabd8470df7745bfb7c342cf408
This required re-centralizing the configuration object for preemptive
circuits, since previously the settings from it were a bit spread out
over the crate.
Allow configurability on preemptive circuits2021-12-07T15:04:41ZNeel Chauhanneel@neelc.org2021-12-07T15:04:41Zurn:sha1:0e9c2d274ef5a1f3a21579d43ced512f17656797