mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-04T18:13:45Z 2022-05-04T18:13:45Z Ian Jackson iwj@torproject.org 2022-05-04T18:13:45Z urn:sha1:a334f17262e80620cfffa3c2ec5f50d4ea49a22f FallbackDir: orports: Introduce and use VecBuilder See merge request tpo/core/arti!474 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T15:16:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:34:40Z urn:sha1:015db3d78d04969971d7254b1a839c5693cb2720 Although these do not appear in the config, it does have a builder. It seems sensible to get rid of this ad-hoc list manipulation site, and replace it with our standard list builder API. define_list_builder_helper requires that the builder element type be Deserialize. Currently GuardUsageRestriction is a transparent, public enum, so we aren't really exposing anything. We could introduce GuardUsageRestrictionBuilder now, but since it's not in the config and thereofore only in the public API of the lower crates, we can definitely put that off. 2022-04-27T12:52:13Z Samanta Navarro ferivoz@riseup.net 2022-04-23T11:51:44Z urn:sha1:c53818d496c910de4dfc4bc8d1f53e419fbf7408 2022-04-25T17:06:26Z Nick Mathewson nickm@torproject.org 2022-04-25T16:40:33Z urn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2 Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021. 2022-03-30T14:40:14Z Nick Mathewson nickm@torproject.org 2022-03-29T12:39:04Z urn:sha1:951b800988ee00048be36a9abf5bcf60eeb19f96 2022-03-30T14:39:09Z Nick Mathewson nickm@torproject.org 2022-03-25T20:56:26Z urn:sha1:ed6389acc7c872854984ae1ea38dbda6542f48cb If we're building a path with the guard manager involved, we now ask the guard manager to pick our first hop no matter what. We only pick from the fallback list ourselves if we're using the API with no guard manager. This causes some follow-on changes where we have to remember an OwnedChanTarget object in a TorPath we've built, and where we gain the ability to say we're building a path "from nothing extra at all." Those are all internal to the crate, though. Closes #220, by making sure that we use our guards to get a fresh netdir (if we can) before falling back to any fallbacks, even if our consensus is old. Compilation should be fixed in the next commit. 2022-03-30T14:39:06Z Nick Mathewson nickm@torproject.org 2022-03-25T20:44:12Z urn:sha1:9da43189f36b19681d10b78ef982c52c929b4573 The guard manager is responsible for handing out the first hops of tor circuits, keeping track of their successes and failures, and remembering their states. Given that, it makes sense to store this information here. It is not yet used; I'll be fixing that in upcoming commits. Arguably, this information no longer belongs in the directory manager: I've added a todo about moving it. This commit will break compilation on its own in a couple of places; subsequent commits will fix it up. 2022-03-30T14:34:48Z Nick Mathewson nickm@torproject.org 2022-03-25T17:38:01Z urn:sha1:80b65c3a4d4108c6b4b0cb91722f89c8e5859b7d This is the logical place for it, I think: the GuardMgr's job is to pick the first hop for a circuit depending on remembered status for possible first hops. Making this change will let us streamline the code that interacts with these objects. 2022-03-30T12:55:58Z Nick Mathewson nickm@torproject.org 2022-03-30T12:55:58Z urn:sha1:700e491813f84d76446193aef7121a329b774717