<feed xmlns='http://www.w3.org/2005/Atom'>
<title>mirrors/arti.git/crates/tor-circmgr/src/path/exitpath.rs, branch arti-v1.2.7</title>
<subtitle>mirror of https://gitlab.torproject.org/tpo/core/arti
</subtitle>
<id>http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.7</id>
<link rel='self' href='http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.7'/>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/'/>
<updated>2024-08-15T17:54:58Z</updated>
<entry>
<title>tor-circmgr: removed unused 'skip_guard_subnet_check' workaround in tests</title>
<updated>2024-08-15T17:54:58Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-15T15:35:49Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=4af7ab716019c85a0373fd82ee22daab3c74a0ce'/>
<id>urn:sha1:4af7ab716019c85a0373fd82ee22daab3c74a0ce</id>
<content type='text'>
</content>
</entry>
<entry>
<title>tor-circmgr: removed unused "chosen exit" functionality</title>
<updated>2024-08-15T17:54:58Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-15T15:32:46Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=e03a2b6cc1f9ee07404c6ac0cd736fc4eba86a99'/>
<id>urn:sha1:e03a2b6cc1f9ee07404c6ac0cd736fc4eba86a99</id>
<content type='text'>
</content>
</entry>
<entry>
<title>tor-circmgr: fix flaky `path::exitpath::test::by_ports` test</title>
<updated>2024-08-13T18:44:24Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-13T18:10:10Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=e0b7f6582283e8cdb721b2df23e99257e4191eb0'/>
<id>urn:sha1:e0b7f6582283e8cdb721b2df23e99257e4191eb0</id>
<content type='text'>
The `path::exitpath::test::by_ports` test sometimes failed now that the
test is using a `GuardMgr` since `select_guard`, when given a chosen
exit, only ensures that the guard and chosen exit are not in the same
family. It does not ensure that the guard and exit do not share an
extended family. This commit relaxes an assertion in the test.

```text
thread 'path::exitpath::test::by_ports' panicked at crates/tor-circmgr/src/path/exitpath.rs:295:9:
assertion failed: r1.can_share_circuit(r3, subnet_config)
```

This "chosen exit" functionality isn't actually being used anywhere
(`ExitPathBuilderInner::ChosenExit` is only ever constructed in tests).
</content>
</entry>
<entry>
<title>tor-circmgr: assert in test that exit path begins with guard</title>
<updated>2024-08-13T01:13:17Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-13T01:12:32Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=2a4208aa0675c966c58fbb368745254545e6e923'/>
<id>urn:sha1:2a4208aa0675c966c58fbb368745254545e6e923</id>
<content type='text'>
</content>
</entry>
<entry>
<title>tor-circmgr: make `GuardMgr` mandatory</title>
<updated>2024-08-13T00:21:53Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-13T00:09:27Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=acf1e81bb8621ec322ebd56b89c47c28958d3bfb'/>
<id>urn:sha1:acf1e81bb8621ec322ebd56b89c47c28958d3bfb</id>
<content type='text'>
Functions that took `Option&lt;&amp;GuardMgr&gt;` now take only `&amp;GuardMgr`.

Three unit tests were removed that covered behaviour when no guard
manager was set.
</content>
</entry>
<entry>
<title>tor-circmg: prepare tests for runtime requirement</title>
<updated>2024-08-12T22:54:22Z</updated>
<author>
<name>Steven Engler</name>
<email>smengler3@gmail.com</email>
</author>
<published>2024-08-12T22:26:35Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=7f13bce5a12e3edbfb6f58d758673a2336ad20ee'/>
<id>urn:sha1:7f13bce5a12e3edbfb6f58d758673a2336ad20ee</id>
<content type='text'>
This wraps some unit tests with `tor_rtcompat::test_with_all_runtimes!`.
This is its own commit to get the indentation changes out of the way and
declutter the following commit.
</content>
</entry>
<entry>
<title>exitpath: Refactor a test to use tor-relay-usage.</title>
<updated>2024-03-28T12:35:48Z</updated>
<author>
<name>Nick Mathewson</name>
<email>nickm@torproject.org</email>
</author>
<published>2024-03-28T12:35:48Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=da4ec973d45a1600a2b262f10a37a4b896cf3065'/>
<id>urn:sha1:da4ec973d45a1600a2b262f10a37a4b896cf3065</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Remove temporary functions in CheckedRelay.</title>
<updated>2024-03-28T12:21:14Z</updated>
<author>
<name>Nick Mathewson</name>
<email>nickm@torproject.org</email>
</author>
<published>2024-03-27T18:09:37Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=dd53eca3a35d5918e13cac50a13f2bb91ce622da'/>
<id>urn:sha1:dd53eca3a35d5918e13cac50a13f2bb91ce622da</id>
<content type='text'>
</content>
</entry>
<entry>
<title>tor-circmgr: Move ExitPathBuilder::from_chosen_exit under the test mod.</title>
<updated>2024-03-20T17:48:14Z</updated>
<author>
<name>Gabriela Moldovan</name>
<email>gabi@torproject.org</email>
</author>
<published>2024-03-20T16:32:25Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=6ad6bc5eb10b4c70fb41268de696e23c66d8fd53'/>
<id>urn:sha1:6ad6bc5eb10b4c70fb41268de696e23c66d8fd53</id>
<content type='text'>
`ExitPathBuilder` is now `pub(crate)`, so we need to move this under the
`test` module to fix the "unused" clippy warning.
</content>
</entry>
<entry>
<title>tor-circmgr: Make the path module crate-private.</title>
<updated>2024-03-20T17:48:14Z</updated>
<author>
<name>Gabriela Moldovan</name>
<email>gabi@torproject.org</email>
</author>
<published>2024-03-20T15:29:39Z</published>
<link rel='alternate' type='text/html' href='http://git.dilluti0n.com/mirrors/arti.git/commit/?id=4c1eb94173521bc5104449327650e20ffe32afa7'/>
<id>urn:sha1:4c1eb94173521bc5104449327650e20ffe32afa7</id>
<content type='text'>
We're not currently using any of the path builders outside of
`tor-circmgr`, so let's make them crate-private for now.

Care must be taken if/when we decide to make them public again. For
instance, the `HsPathBuilder` exposes two path building functions, one
that uses vanguards, and one that doesn't. We want to strongly encourage
the use of the vanguards-aware version of the function whenever the
`vanguards` feature is enabled, without breaking any of its existing
non-vanguard uses.

Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2046#note_3010217
</content>
</entry>
</feed>
