mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.1.0 2022-02-17T13:31:03Z 2022-02-17T13:31:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-17T11:24:56Z urn:sha1:2d4901ccdefcf14e1a56bbbd06584a90f607c6c1 2022-02-16T19:35:06Z Nick Mathewson nickm@torproject.org 2022-02-16T17:52:32Z urn:sha1:96d856e2640011a7aeb0c5ecef4d787e0fb9b610 There are a couple of tricky ones I'll do separately. 2022-02-16T19:35:06Z Nick Mathewson nickm@torproject.org 2022-02-16T17:04:32Z urn:sha1:900007585a8aa6731262474610f3c3c4431603ba 2021-12-13T04:29:53Z Neel Chauhan neel@neelc.org 2021-12-13T04:29:53Z urn:sha1:52cae03621c61f7fcf95951dba087719e8ba6168 2021-12-07T16:01:30Z eta tor@eta.st 2021-12-07T16:01:30Z urn:sha1:a3f2e32485219a6e7b6776a506997b6e1c193193 Squash, refactor, and test !139 (Don't use same family as exit when picking a guard) Closes #183 See merge request tpo/core/arti!173 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. 2021-12-06T15:48:27Z Nick Mathewson nickm@torproject.org 2021-12-06T15:48:27Z urn:sha1:2c2f774bd1f1d5b30eddd4a95a0f0b102a7651c8 Just as `in_same_family` is a member of Relay, so the function for getting all the real family members of a relay should belong in the same crate. This change also removes the `family()` accessor: it gives the _claimed_ family rather than the _acknlowedged_ family, and is therefore a bit dangerous. There's still a hole in this logic; I've noted it in the Limitations section. If we get a microdescriptor for a relay in between creating and using the guard restriction, it might be omitted from the family list. 2021-12-06T14:44:56Z Nick Mathewson nickm@torproject.org 2021-12-06T14:44:56Z urn:sha1:cfc31dadd4aec2c4ea164163ed63cb33058257ec This approach saves us from a linear search when picking guards. 2021-12-06T14:26:32Z Nick Mathewson nickm@torproject.org 2021-12-06T14:26:32Z urn:sha1:54971e3c9ad95b981828438ebebad1da6c6dfd8d There's not much reason to use a HashSet here, since we're just going over the whole list. This reverts commit 16e8489abbea1581b8e2 and does a little more refactoring. 2021-12-06T14:05:48Z Neel Chauhan neel@neelc.org 2021-11-22T22:51:46Z urn:sha1:b0016682c30b6db5b9180a17852c00603b40e715