mirrors/arti.git/crates/tor-circmgr/src/path/dirpath.rs, branch arti-v1.1.2

Allow clippy::unchecked_duration_subtraction in tests

2023-01-27T13:28:02Z

This panics on error, and we're fine with a panic on misbehavior in tests.

Refactor external guardmgr APIs: Stop taking NetDir arguments.

2022-11-08T13:10:15Z

These arguments were used only for legacy (testing) purposes; the tests now use `TestNetDirProvider`. This lets us simplify our internal logic for passing a `NetDir` to our samples, and prepare for having a `BridgeSet` to pass there instead. This is a breaking change to `guardmgr` and `circmgr`.

guardmgr config: Introduce and require new GuardMgrConfig trait

2022-11-03T15:43:41Z

It doesn't seem to me like it makes sense to provide the backward compatibility here.

Allow "clippy::single_char_pattern" in tests.

2022-10-12T12:50:29Z

This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome.

Final (?) API revisions for tor-linkspec

2022-08-10T14:39:37Z

With this change, each individual identity type becomes optional. The functions that expose them unconditionally are now in a "legacy" trait that only some downstream types are expected to implement. There are new convenience APIs in HasRelayIds: * to return Option<&keytype>, * to see if one identity-set contains another. This commit will break several downstream crates! For the reviewer's convenience, I will put the fixes for those crates into a series of squash! commits on this one. tor-netdir ---------- Revise tor-netdir to accept optional identities. This required some caveats and workarounds about the cases where we have to deal with a key type that the tor-netdir code does not currently recognize at all. If we start to add more identity types in the future, we may well want more internal indices in this code. tor-proto --------- In order to make tor-proto support optional identities, there were fewer changes than I thought. Some "check" functions needed to start looking at "all the ids we want" rather than at "the two known IDs"; they also needed to accommodate that case where we don't have an ID that we demand. This change will also help with bridges, since we want to be able to connect to a bridge without knowing all of its IDs up front. The protocol currently _requires_ the two current ID types in some places. To deal with that, I added a new `MissingId` error. I also removed a couple of unconditional identity accessors for chanmgr; code should use `target().identity(...)` instead. tor-chanmgr ----------- This is an incomplete conversion: it does not at all handle channel targets without Ed25519 identities yet. It still uses those identities to index its internal map from identity to channel; but it gives a new `MissingId` error type if it's given a channel target that doesn't have one. We'll want to revise the map type again down the road when we implement bridges, but I'd rather not step on the channel-padding work in progress right now. tor-guardmgr ------------ This change is mostly a matter of constructing owned identity types more sensibly, rather than unwrapping them directly. There are some places marked with TODOs where we still depend on particular identity types, because of how the directory protocol works. This will need revisiting when we add bridge support here. tor-circmgr ----------- These changes are just relatively simple API changes in the tests.

tor-linkspec: Refactor out traits to represent a relay's ID set.

2022-08-02T16:40:23Z

We want the set of identities supported by a relay to be extensible in the future with minimal fuss; we'd also like to make working with these ID sets more convenient. To handle that, this commit adds a new trait for "Something that has the same IDs as a relay" and a new object for "an owned representation of a relay's IDs." This commit introduces a similar trait for "Something with a list of SocketAddr, like a relay has." There's no owned equivelent for that, since Vec is already a thing. Closes #428.

circmgr: Refactor DirPathBuilder::pick_path.

2022-07-12T16:05:35Z

We no longer needs to have a "return" at the end of each match block.

circmgr: Use FilterCounts to explain why we couldn't build paths

2022-07-12T16:02:12Z

Add more information to failed-to-select fallback errors.

2022-07-07T17:16:06Z

Also re-order the filters to be a little more logical.

clippy: Consolidate many lints in maint/add_warning

2022-06-24T13:23:38Z

Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead.