mirrors/arti.git/crates/tor-circmgr/src/path.rs, branch arti-v1.4.0

tor-circmgr: removed unused "chosen exit" functionality

2024-08-15T17:54:58Z

tor-circmgr: fix flaky `path::exitpath::test::by_ports` test

2024-08-13T18:44:24Z

The `path::exitpath::test::by_ports` test sometimes failed now that the test is using a `GuardMgr` since `select_guard`, when given a chosen exit, only ensures that the guard and chosen exit are not in the same family. It does not ensure that the guard and exit do not share an extended family. This commit relaxes an assertion in the test. ```text thread 'path::exitpath::test::by_ports' panicked at crates/tor-circmgr/src/path/exitpath.rs:295:9: assertion failed: r1.can_share_circuit(r3, subnet_config) ``` This "chosen exit" functionality isn't actually being used anywhere (`ExitPathBuilderInner::ChosenExit` is only ever constructed in tests).

tor-circmgr: make `GuardMgr` mandatory

2024-08-13T00:21:53Z

Functions that took `Option<&GuardMgr>` now take only `&GuardMgr`. Three unit tests were removed that covered behaviour when no guard manager was set.

tor-circmgr: Add a TODO about an unused restriction.

2024-06-20T12:12:55Z

tor-circmgr: If the path is invalid, display the offending hops in the error.

2024-06-03T19:05:31Z

tor-circmgr: Ensure pick_path() builds paths with unique hops (fmt).

2024-06-03T19:05:31Z

tor-circmgr: Ensure pick_path() builds paths with unique hops.

2024-06-03T19:05:31Z

We now return an internal error if the path we've just built contains the same hop in multiple positions.

tor-circmgr: Exclude the circ target when building paths.

2024-06-03T19:05:31Z

Closes #1425

Remove temporary functions in CheckedRelay.

2024-03-28T12:21:14Z

tor-circmgr: Make the path module crate-private.

2024-03-20T17:48:14Z

We're not currently using any of the path builders outside of `tor-circmgr`, so let's make them crate-private for now. Care must be taken if/when we decide to make them public again. For instance, the `HsPathBuilder` exposes two path building functions, one that uses vanguards, and one that doesn't. We want to strongly encourage the use of the vanguards-aware version of the function whenever the `vanguards` feature is enabled, without breaking any of its existing non-vanguard uses. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2046#note_3010217