mirrors/arti.git/crates/tor-circmgr/src/impls.rs, branch arti-v1.4.3

circ: Remove CircParameters reference in call stack

2025-04-23T18:36:28Z

This avoids cloning the object and instead allows us to have a CircParameters per hop on the circuit path. This will come handy with congestion control where each hop might have different congestion control parameters. Part of #1817 Signed-off-by: David Goulet

squash! Upgrade rand dependency to 0.9.

2025-03-18T16:09:44Z

- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`

circmgr: Remove the CircParameters build .expect()

2025-01-16T14:16:01Z

Instead, return an error and make all call site handle it. Signed-off-by: David Goulet

circ: Specialize the circparams from netparams function

2025-01-16T14:16:01Z

Congestion control parameters have specific values depending on the circuit type. Instead of using a CircuitType, which is removed in this commit, specialize the function in this case onion and exit. This allows us to get rid of CircuitType and solely use TargetCircUsage instead. At this commit, we use .expect() on the Builder. Future commit will remove this to return a Result in case of failure. Worth noting that we don't expect one. Signed-off-by: David Goulet

circmgr: Modify CircParameters for congestion control

2025-01-16T14:16:01Z

The congestion control parameters are created from the consensus parameters (netparams) and then put into the CircParameters object that is then passed down the tor-proto crate. Because different parameters are selected depending on the circuit type (onion vs exit vs sbws), a CircuitType enum is introduced for the sole purpose of being used to select the right parameters. Related #534 Signed-off-by: David Goulet

CircMgr: Start writing tests.

2024-10-03T12:56:16Z

CircMgr: Make CircMgr and HsCircPool generic over builder type.

2024-09-24T13:45:21Z

This will allow for testing, as the CircuitBuilder can be replaced with a mocked version. This did require moving some of what was in the CircuitBuilder impl into the AbstractCircuitBuilder type, since Drop implementations can't be specialized, but that's fine, as we'll probably be doing more of that in the future anyways.

tor-circmgr: Remove AbstractSpec and FakeSpec.

2024-09-16T14:57:33Z

AbstractSpec and FakeSpec actually make testing more difficult, since they prevent using FakeBuilder in code that relies on the concrete TargetCircUsage and SupportedCircUsage types. Removing them means FakeBuilder can be used in more places, and also means that the test code is closer to the real code, since TargetCircUsage and SupportedCircUsage are now exercised directly in more tests. This did require making one change to a test, which I think was previously testing behaviour that was true for FakeSpec but not for the real code: The mgr::test::isolated test previously asserted that, in the case where three circuits were requested, two with isolation and one without, the non-isolated circuit would be shared with one of the isolated circuits. This was allowed by the FakeSpec::supports function. However, in the actual code, the path is as follows: * AbstractCircMgr::get_or_launch * AbstractCircMgr::prepare_action * CircList::find_open * AbstractSpec::find_supported * abstract_spec_find_supported * OpenEntry::supports * SupportedCircUsage::supports * StreamIsolation::compatible_same_type StreamIsolation::compatible_same_type checks owner_type, which is always zero for non-isolated streams and always non-zero for isolated streams, meaning that a isolated stream will never be compatible with a non-isolated stream. The seems like desirable behaviour, so I simply modified the test to make four connections, two isolated and two not, and checked that the isolated streams never share any circuits, and that the two non-isolated streams use the same circuit. As far as I can tell, this is the intended behaviour in the existing code.

tor-circmgr: make `GuardMgr` mandatory

2024-08-13T00:21:53Z

Functions that took `Option<&GuardMgr>` now take only `&GuardMgr`. Three unit tests were removed that covered behaviour when no guard manager was set.

tor-circmgr: Remove addressed TODO.

2024-04-05T11:16:11Z

This was addressed in !2046, but I forgot to remove the TODO.