mirrors/arti.git/crates/tor-circmgr/src/impls.rs, branch arti-v1.2.8

CircMgr: Make CircMgr and HsCircPool generic over builder type.

2024-09-24T13:45:21Z

This will allow for testing, as the CircuitBuilder can be replaced with a mocked version. This did require moving some of what was in the CircuitBuilder impl into the AbstractCircuitBuilder type, since Drop implementations can't be specialized, but that's fine, as we'll probably be doing more of that in the future anyways.

tor-circmgr: Remove AbstractSpec and FakeSpec.

2024-09-16T14:57:33Z

AbstractSpec and FakeSpec actually make testing more difficult, since they prevent using FakeBuilder in code that relies on the concrete TargetCircUsage and SupportedCircUsage types. Removing them means FakeBuilder can be used in more places, and also means that the test code is closer to the real code, since TargetCircUsage and SupportedCircUsage are now exercised directly in more tests. This did require making one change to a test, which I think was previously testing behaviour that was true for FakeSpec but not for the real code: The mgr::test::isolated test previously asserted that, in the case where three circuits were requested, two with isolation and one without, the non-isolated circuit would be shared with one of the isolated circuits. This was allowed by the FakeSpec::supports function. However, in the actual code, the path is as follows: * AbstractCircMgr::get_or_launch * AbstractCircMgr::prepare_action * CircList::find_open * AbstractSpec::find_supported * abstract_spec_find_supported * OpenEntry::supports * SupportedCircUsage::supports * StreamIsolation::compatible_same_type StreamIsolation::compatible_same_type checks owner_type, which is always zero for non-isolated streams and always non-zero for isolated streams, meaning that a isolated stream will never be compatible with a non-isolated stream. The seems like desirable behaviour, so I simply modified the test to make four connections, two isolated and two not, and checked that the isolated streams never share any circuits, and that the two non-isolated streams use the same circuit. As far as I can tell, this is the intended behaviour in the existing code.

tor-circmgr: make `GuardMgr` mandatory

2024-08-13T00:21:53Z

Functions that took `Option<&GuardMgr>` now take only `&GuardMgr`. Three unit tests were removed that covered behaviour when no guard manager was set.

tor-circmgr: Remove addressed TODO.

2024-04-05T11:16:11Z

This was addressed in !2046, but I forgot to remove the TODO.

tor-circmgr: Give pick_path a VanguardMgr.

2024-03-20T17:48:14Z

tor-circmgr: Add more vanguards TODOs.

2024-03-20T17:48:14Z

tor-circmgr: Add UniqId to Error::GuardNotUsable.

2024-02-27T17:01:28Z

Part of #1297

Refactor ClientCirc APIs to use Arc.

2023-05-16T13:02:09Z

Now ClientCirc is no longer `Clone`, and the things that need it to be `Clone` instead return and use an Arc We're doing this so that ClientCirc can participate in the RPC system, and so that its semantics are more obvious. Closes #846. Thanks to the type system, this was a much simpler refactoring than I had feared it would be.

Provide ChannelUsage and plumb it all the way down

2022-08-16T17:37:06Z

Channel padding depends on what the channel is being used for. We therefore need to let the channel code know this information. The implementation of the per-channel padding control logic will be in the new note_usage function, which for now is simply a stub. A future commit will introduce a `PaddingControlState` which lives in the channel frontend; consult the doc comment for that type to see why the plumbing through the channel manager terminates in the channel frontend.

squash! Bump every crate's edition to 2021.

2022-04-25T17:06:26Z

Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021.