mirrors/arti.git/crates/tor-circmgr/src/hspool/pool.rs, branch arti-v1.2.8 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.8 2024-09-24T13:45:21Z CircMgr: Make CircMgr and HsCircPool generic over builder type. 2024-09-24T13:45:21Z Wesley Aptekar-Cassels me@wesleyac.com 2024-09-16T16:35:37Z urn:sha1:e6f0b59e595f5ab5bd8d58d3c6aab8dface9a851 This will allow for testing, as the CircuitBuilder can be replaced with a mocked version. This did require moving some of what was in the CircuitBuilder impl into the AbstractCircuitBuilder type, since Drop implementations can't be specialized, but that's fine, as we'll probably be doing more of that in the future anyways. tor-circmgr: Make retire_all_circuits unconditional. 2024-06-03T14:28:23Z Gabi Moldovan gabi@gotpcrel.net 2024-06-03T12:22:42Z urn:sha1:2475f71a6b664fcedba8fe446100bd6cb3765431 Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2168?commit_id=3c67fa55c7c5b0c4f30c1d57e8e67fe541d9c99e#note_3033368 tor-circmgr: Remove VanguardMode from Pool (fmt). 2024-06-03T14:28:22Z Gabriela Moldovan gabi@torproject.org 2024-05-23T16:40:51Z urn:sha1:2deb0b5df8c7d7e14ab151781b3f3b30180aa210 tor-circmgr: Remove VanguardMode from Pool. 2024-06-03T14:19:24Z Gabriela Moldovan gabi@torproject.org 2024-05-23T16:38:33Z urn:sha1:d75f136e506e474274529e4d0fee742d5b5d9011 Storing the VanguardMode in multiple places (in the VanguardMgr *and* the HS circ Pool) is dangerous and can lead to split brain situations where different parts of the code think they are running in different VanguardModes. See #1424 tor-circmgr: Remove dangerous vanguards_enabled() function. 2024-06-03T14:19:24Z Gabriela Moldovan gabi@torproject.org 2024-05-23T16:12:19Z urn:sha1:59e2c5c4e599f48670bce05e295523873b276684 `VanguardMgr` should be the source of truth for obtaining the current `VanguardMode`. Closes #1424 tor-guardmgr: Replace From impl with VanguardConfig::mode accessor. 2024-06-03T09:47:32Z Gabriela Moldovan gabi@torproject.org 2024-05-16T13:15:56Z urn:sha1:d64f62abe379e673591d20b36dfbb638aa5f263d tor-guardmgr: Use ExplicitOrAuto in the VanguardConfig 2024-06-03T09:47:32Z Gabriela Moldovan gabi@torproject.org 2024-05-13T13:43:52Z urn:sha1:d434d3266ceadfa1446f20e6f9f26d9c585b9c42 tor-guardmgr: Unconditionally define VanguardConfig. 2024-06-03T09:47:32Z Gabriela Moldovan gabi@torproject.org 2024-05-13T13:13:30Z urn:sha1:d17dc599c09af08ef501dfba3a685081491bb17a We want to export the `VanguardConfig` even if the `vanguards` feature is disabled (we will need to unconditionally include it in the arti config). Note that if `vanguards` are disabled, the `VanguardMode` from the `VanguardConfig` can only be `Dsiabled`. tor-circmgr: Replace STUB/STUB+ terminology with SHORT/EXTENDED (fmt). 2024-05-16T10:59:44Z Gabriela Moldovan gabi@torproject.org 2024-05-16T10:59:44Z urn:sha1:a59ff02246247f9687d86f80cc4ab8407e43cccb tor-circmgr: Replace STUB/STUB+ terminology with SHORT/EXTENDED. 2024-05-16T10:49:15Z Gabriela Moldovan gabi@torproject.org 2024-05-16T10:49:15Z urn:sha1:bb01d960a05e24ffb9faae125b95c4c64c2e43ee The previous STUB/STUB+ terminology was confusing, because STUB and STUB+ are both "circuit stubs" (but STUB is shorter than STUB+). Closes #1339