mirrors/arti.git/crates/tor-circmgr/src/config.rs, branch arti-v1.1.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.2 2023-01-27T13:28:02Z Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. guardmgr config: Introduce and require new GuardMgrConfig trait 2022-11-03T15:43:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-03T14:03:51Z urn:sha1:6c64be06a6c80de50e3a6725aabce47ae401df47 It doesn't seem to me like it makes sense to provide the backward compatibility here. CircMgr: Enable reachable_addrs filter. 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-09T22:01:15Z urn:sha1:34e8e208cc02b017b3e24914af465aa9c2d15f64 Add a configuration option for reachable_addrs 2022-06-17T12:47:57Z Nick Mathewson nickm@torproject.org 2022-06-09T21:22:37Z urn:sha1:1c5f540dc87d30b73574f4e5429665c6d9d72077 (This doesn't do anything yet.) impl_standard_builder: Have it generate FooConfig::builder 2022-05-12T17:50:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T17:15:39Z urn:sha1:be5bc04c02d5023c46a117a048bf0a659094f4eb This deletes many handcoded impls. It also generates lots of impls that we previously didn't have. Rename impl_standard_builder from impl_default_via_builder 2022-05-12T14:59:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:58:58Z urn:sha1:c1c6f2b376827c4ebb13bc08456f8355717d15e5 I have Plans for this macro. In particular: * I have a wip branch which tests that the Builder can be deserialised from an empty config (ie, that config reading of a config with a blank section for this item works). * I think we should autogenerate $Config::builder(), and promote that, rather than $ConfigBuilder::default(). This macro could do that. config: Replace more handwritten impl Default 2022-05-12T14:59:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:35:44Z urn:sha1:888d6e0511d01379d42ae154ac99ce2d9e84fd44 Add correct serde(default) attrs for humantime_serde::option 2022-05-12T10:34:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T09:09:46Z urn:sha1:04b8729d6baf411847ec89d29b97848781a96dbb Discovered by a test case in my local tree. The test case was macro-generated by an extension of impl_standard_builder (which macro istself currently awaiting review, arti!499) Have also sent an MR to update the upstream docs https://github.com/jean-airoldie/humantime-serde/pull/8 config derive attrs: Make builders serde, and validated structs not 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.)