mirrors/arti.git/crates/tor-circmgr/src/config.rs, branch arti-v0.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.02022-05-05T09:35:52Zconfig derive attrs: Make builders serde, and validated structs not2022-05-05T09:35:52ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-04T16:45:25Zurn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861
* Builders additionally derive: Debug, Serialize, Deserialize.
* Validated structs no longer derive: Serialize, Deserialize
and all related attributes deleted.
* As a consequence, all the `#[serde(deny_unknown_fields)]`
are gone. That means that right now unknown fields are totally
ignored. This is good for compatibility but poor for useability.
Doing something better here is arti#417, in progress.
* As a consequence, delete tor_dirmgr::retry::default_parallelism.
(The default value was already duplicated into a builder attr.)
Change builder list API2022-05-04T12:50:10ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-04T12:32:35Zurn:sha1:4bca91271558d950092fb1ac51c1316655d293cb
The new API is (roughly) as discussed in
https://gitlab.torproject.org/tpo/core/arti/-/issues/451
This is quite a large commit and it is not convenient to split it up.
It contains the following changes:
* Redo the list builder and accessor macros implemnetation,
including docs and tests.
* Change uses of define_list_config_builder. In each case:
- Move the docs about the default value to the containing field.
- Remove the other docs (which were just recapitulations, and
are now not needed since the ListBuilder is no longer public).
- Rewmove or replace `pub` in the define_list_builder_helper call,
so that the builder is no longer public.
- Change the main macro call site to use define_list_builder_helper.
- Add a call to define_list_builder_accessors.
* Make the module `list_builder` pub so that we have somewhere to
put the overview documentation.
* Consequential changes:
- Change `outer.inner().replace(X)` to `outer.set_inner(X)`
- Consequential changes to imports (`use` statements).
Document defaults for all the config lists2022-04-25T17:22:54ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T16:38:40Zurn:sha1:ce877e442124cb61a38ffe4ab7b3f29ff1b3541f
And add an imprecation in define_list_config_builder's doc comment do
do so in future for other invocations of the macro.
Add add the missing full stops.
Use better syntax for doc comment attribute2022-04-25T16:05:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T15:49:42Zurn:sha1:dca4f3ede107ec343e733f580723140437cc8c7f
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/471#note_2798020
Introduce PredictedPortsListBuilder2022-04-25T16:05:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-04-25T13:33:03Zurn:sha1:24518675dbd2e649b554ecc0117ea62ede11b292
This means that `NetworkConfig::initial_predicted_ports` is now like
the other list-like things, returning `&mut list_builder` with the same
`set()` and `append()` methods.
Use a lower default for max_retries.2022-03-30T18:22:28ZNick Mathewsonnickm@torproject.org2022-03-30T18:22:28Zurn:sha1:432bb5ce627a5add1ed2c68130cfaa2d60672900
The older default seems (experimentally) to be ridiculously high.
Generally, if we can't build a circuit within a handful attempts,
that circuit has already timed out... unless there is a fast-failure
condition, in which case we're just hammering the network (or our
view of it.)
Found with `arti-testing` for #329.
Turn FallbackList into a real type, and store one in GuardMgr.2022-03-30T14:39:06ZNick Mathewsonnickm@torproject.org2022-03-25T20:44:12Zurn:sha1:9da43189f36b19681d10b78ef982c52c929b4573
The guard manager is responsible for handing out the first hops of
tor circuits, keeping track of their successes and failures, and
remembering their states. Given that, it makes sense to store this
information here. It is not yet used; I'll be fixing that in
upcoming commits.
Arguably, this information no longer belongs in the directory
manager: I've added a todo about moving it.
This commit will break compilation on its own in a couple of places;
subsequent commits will fix it up.
Merge branch 'config-partials-transparent' into 'main'2022-03-17T12:30:46ZIan Jacksoniwj@torproject.org2022-03-17T12:30:46Zurn:sha1:40bede587c8d9a0a29ad103832a9c9cd4a2f5982
Absolish builders for CircMgrConfig and DirMgrConfig
See merge request tpo/core/arti!417Add rationale for CircMgrConfig transparency and trait2022-03-16T19:31:08ZIan Jacksonijackson@chiark.greenend.org.uk2022-03-16T19:30:21Zurn:sha1:ab352881e3d010b575c6c6495e37b4ee90facae4Provide define_accessor_trait and use it to generate CircMgrConfig2022-03-16T19:31:05ZIan Jacksonijackson@chiark.greenend.org.uk2022-03-16T19:30:10Zurn:sha1:82aa4b902a77ce703cbb94a36c6265143741285b