mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.0 2022-11-23T18:28:38Z 2022-11-23T18:28:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-23T15:20:18Z urn:sha1:b822e2ebe9941ba5e551b6f112239a395517def3 This 1. Makes the errors smaller 2. Redacts (currently, scrubs) the chantarget when safe logging is enabled The other error variants in tor-circmgr::Error don't seem to contain information that should become sensitive as part of bridge support. 2022-10-06T19:13:05Z Nick Mathewson nickm@torproject.org 2022-10-05T18:08:40Z urn:sha1:299ebd729d697cde69dc720e358abf933af2a054 These are now builders. 2022-08-17T09:54:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-08-11T10:39:39Z urn:sha1:3aed28acd42dbf5342932e2f6f42cc2ddbbe8c50 As suggested in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827246 2022-08-17T09:54:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-08-08T15:33:33Z urn:sha1:5db974ef72eb1250ab27cd7e21141f64d8778776 Replace Channel::note_usage with Channel::engage_padding_activities, which unconditionally causes the channel to (start to) do netflow padding things. The condition now lives in chanmgr. Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826094 2022-08-17T09:54:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-08-08T12:47:02Z urn:sha1:48fc5d3c39ccb8de3d3b52f34c5c76cae6806714 This gets rid of many Result(). Many parameters are renamed. Test cases of the now-impossible branch are removed. Deleting the match from padding_parameters will come in a moment. I've split off that commit since it has much whitespace noise. for now, change the error type to Void. 2022-08-16T17:39:57Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-27T19:34:43Z urn:sha1:76a1c45202cf35588780112d8400d50bd08f9926 This commit is just the necessary plumbing. The config is currently empty. We'll add something to it, for padding control, later. 2022-08-16T17:37:06Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-26T18:14:12Z urn:sha1:8d44ef05dc7cd3d16f024d7b1058c16ecf54ee92 Channel padding depends on what the channel is being used for. We therefore need to let the channel code know this information. The implementation of the per-channel padding control logic will be in the new note_usage function, which for now is simply a stub. A future commit will introduce a `PaddingControlState` which lives in the channel frontend; consult the doc comment for that type to see why the plumbing through the channel manager terminates in the channel frontend. 2022-08-16T17:37:06Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-27T19:29:35Z urn:sha1:4f44ef755aeea74f6df9fc01dcf2a4843875d7b8 The chanmgr remembers the last dormancy state it was told. We invent a chanmgr-specific Dormancy which the arti-client code knows how to convert from the richer top-level dormant status. This avoids having to have everyone know all the variants of the top-level state. To call reconfigure_general, we must also obtain and plumb through a netdir. Right now we must return an internal error if there is in fact no netdir, because reconfigure_general does not yet cope with a missing netdir. Nothing actually *uses* the dormancy yet. 2022-08-10T14:39:36Z Nick Mathewson nickm@torproject.org 2022-08-03T20:34:40Z urn:sha1:8af41bd65feb80fcbacf2478e9422a1d6ec0d654 (It's safe to require these specific keys, since we constructed the objects for testing, and we know for certain that they contain given keys.) 2022-08-02T18:19:00Z Nick Mathewson nickm@torproject.org 2022-08-02T18:10:54Z urn:sha1:fdfc5f29e31bb69488482ee01a891134e9f16b83 This method tells if two HasRelayIds contain exactly the same set of Relay identities, and is generally useful for debugging.