mirrors/arti.git/crates/tor-checkable/src, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-23T14:44:55Ztor-checkable: TODO for TimerangeBound from Timebound2026-06-23T14:44:55ZClara Englercve@cve.cx2026-06-23T12:26:37Zurn:sha1:3f5984d9f2ceefeb7406531d01f1259c15c87487tor-checkable: Specify Timebound inclusiveness in rustdoc2026-06-11T09:01:37ZClara Englercve@cve.cx2026-06-11T09:01:37Zurn:sha1:91a14182d48bc9faa9974ae3d2547cab56b20298
This commit updates Timebound's rustdoc to require inclusiveness when
checking the timeliness of a given object.
tor-checkable: TimerangeBound: test edge cases2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T09:59:51Zurn:sha1:8dad38573005e533d78e0be581901590ffd5a1fbtor-checkable: TimeRangebound: document inclusivity2026-06-10T14:42:10ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-10T08:54:30Zurn:sha1:b3ff5544712722bd954a8fac4b90f9d3694d4273tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusive (fmt)2026-06-10T14:41:46ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T14:11:40Zurn:sha1:da7de707ae1af8c5fbf1c583412da1aaf0918202tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusive2026-06-10T14:41:46ZIan Jacksonijackson@chiark.greenend.org.uk2026-06-04T14:07:48Zurn:sha1:28434bbe2a372354824b8424743e3ce8738bef46
This makes more sense because:
* `start_bound` and `end_bound` return `Bound::Included`
* It doesn't make sense to say that a document isn't valid at
the very start of its validity period. (And we don't want a half-open range.)
* NotYetValid(0ns) and Expired(0ns) are rather nonsensical errors.
In real timeliness tests it will make no difference since the current
time is only equal to the bound for a nanosecond. But tests that like
to test corner cases might be affected, and possibly some synthetic
situations (where the document's own validity time start is used
somehow) might change.
maint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-checkable: Port to web-time-compat2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T13:23:45Zurn:sha1:40f1f116f49dd2815a94704e6ccc1b9c5a5a17e0Allow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Run script to add new warning2026-01-27T18:05:36ZGabriela Moldovangabi@torproject.org2026-01-27T18:05:36Zurn:sha1:a98faf72eb06b47700faeeac5a8a0dd0fc29b584
This adds the lint to all our crates.