mirrors/arti.git/crates/tor-checkable/src/timed.rs, branch arti-v2.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.0 2026-06-10T14:42:10Z tor-checkable: TimerangeBound: test edge cases 2026-06-10T14:42:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-10T09:59:51Z urn:sha1:8dad38573005e533d78e0be581901590ffd5a1fb tor-checkable: TimeRangebound: document inclusivity 2026-06-10T14:42:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-10T08:54:30Z urn:sha1:b3ff5544712722bd954a8fac4b90f9d3694d4273 tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusive (fmt) 2026-06-10T14:41:46Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-04T14:11:40Z urn:sha1:da7de707ae1af8c5fbf1c583412da1aaf0918202 tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusive 2026-06-10T14:41:46Z Ian Jackson ijackson@chiark.greenend.org.uk 2026-06-04T14:07:48Z urn:sha1:28434bbe2a372354824b8424743e3ce8738bef46 This makes more sense because: * `start_bound` and `end_bound` return `Bound::Included` * It doesn't make sense to say that a document isn't valid at the very start of its validity period. (And we don't want a half-open range.) * NotYetValid(0ns) and Expired(0ns) are rather nonsensical errors. In real timeliness tests it will make no difference since the current time is only equal to the bound for a nanosecond. But tests that like to test corner cases might be affected, and possibly some synthetic situations (where the document's own validity time start is used somehow) might change. maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. tor-checkable: Port to web-time-compat 2026-03-26T19:20:16Z Nick Mathewson nickm@torproject.org 2026-03-26T13:23:45Z urn:sha1:40f1f116f49dd2815a94704e6ccc1b9c5a5a17e0 Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning TimerangeBound: Stop using std::ops::Bound. 2024-11-25T18:20:11Z Wesley Aptekar-Cassels me@wesleyac.com 2024-10-15T13:58:29Z urn:sha1:1659495eb30ae6a17058418b6d00592373cfdf65 Fixes: #1691 Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c tor-checkable: Use checked arithmetic 2024-03-05T22:19:10Z Tobias Stoeckmann tobias@stoeckmann.org 2024-03-05T22:16:12Z urn:sha1:522c2ebc4563984bcf6a6222a1a693468b6baca5 Make sure that arithmetic with SystemTime and Duration fits into SystemTime. If the result does not fit, set the affected boundary to None. After all it implies that this point in time is not reachable on the system. Avoids integer overflow or panic, depending on debug or release build.