mirrors/arti.git/crates/tor-chanmgr/src, branch arti-v1.3.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.22025-01-07T14:04:53ZMerge branch 'mod-module-files' into 'main'2025-01-07T14:04:53ZNick Mathewsonnickm@torproject.org2025-01-07T14:04:53Zurn:sha1:5d0bbc76dc44ff98b5f32c69168b07246e65afa7
clippy: deny `mod_module_files`
See merge request tpo/core/arti!2689clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
fix: fix typos2025-01-06T20:36:37ZDimitris Apostoloudimitris.apostolou@icloud.com2024-12-25T20:48:02Zurn:sha1:4acfc23b70c51d2637d0274943a82d1c94dec050add_warnings, *: Allow clippy::needless_lifetimes2024-12-03T14:27:26ZNick Mathewsonnickm@torproject.org2024-12-03T14:15:50Zurn:sha1:64cc3f2ed3eea0b7c5cc89ae07cbdadfdc1646fb
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
tor-chanmgr: remove immediately awaited async block expression2024-11-27T19:11:58ZSteven Engleropara@torproject.org2024-11-26T20:17:59Zurn:sha1:278a678c1f3cd36bdc805df439f01cde6dfa02f6
This shouldn't be needed anymore now that we use a `Defer`.
tor-chanmgr: use `Defer` in `AbstractChanMgr` to handle cancellations2024-11-27T19:10:41ZSteven Engleropara@torproject.org2024-11-26T20:13:24Zurn:sha1:935176f245e711fe270d86010c310e6c0a0410c4tor-chanmgr: add `util::defer` module2024-11-27T19:09:22ZSteven Engleropara@torproject.org2024-11-26T20:11:14Zurn:sha1:d9c150b4a604ad23b98be82b00f718720265e11a
This contains the `Defer` type, which can be used to defer a closure
until the `Defer` is dropped.
tor-chanmgr: change `RequestCancelled` retry from `Never` to `Immediate`2024-11-21T18:35:57ZSteven Engleropara@torproject.org2024-11-21T18:29:26Zurn:sha1:f6f33ef982263aa2db981e87a3657e35b9c0c730
If the channel request was cancelled, we should be able to retry
immediately. Additionally, the `kind()` of `RequestCancelled` is
`TransientFailure`, and I don't think it make sense for a transient
error to return a `retry_time()` of `Never`.
tor-chanmgr: fix reconfigure bug when given `CheckAllOrNothing`2024-11-12T23:48:36ZSteven Engleropara@torproject.org2024-11-05T22:00:55Zurn:sha1:d7de30057914067faeee2bf8619661f11f3ad086
We shouldn't actually reconfigure anything if given `CheckAllOrNothing`.
tor-chanmgr: remove panics in debug builds2024-11-12T01:27:27ZSteven Engleropara@torproject.org2024-11-12T01:23:04Zurn:sha1:cad2a7288bfb71b456e1f7690349cf721c421872
These were supposed to fail loudly in debug builds by panicking, but
panics are mostly useless for debugging in async applications that use a
runtime which catches panics. So we'll just log the error instead.