mirrors/arti.git/crates/tor-chanmgr/src, branch arti-v1.2.7

extract tor_async_utils::oneshot into ::oneshot-fused-workaround

2024-08-28T14:27:46Z

Having this in the `tor-async-utils` crate prevents us from doing both of the following without introducing a circular dependency: * using it in `tor-rtmock` (which we currently do, particularly in tests). * using `tor-rtmock` to test things in `tor-async-utils`. We don't do this yet, but it is generally sensible to do so. In particular we want to move the `stream_peak` module there, which is currently tested with `tor-rtmock`. Moving this into its own crate avoids this circular dependency.

Merge branch 'chan_arc' into 'main'

2024-05-28T11:45:02Z

Proto: Refactor Channel to always be Arc. See merge request tpo/core/arti!2163

chanmgr: Delegate to Channel::engage_padding_activities explicitly.

2024-05-17T18:16:15Z

(This isn't a bugfix, but it helps avoid the appearance of a function calling itself. This _would_ become a bug if we imported the wrong trait into scope here.)

Make Channel non-Clone.

2024-05-16T16:24:12Z

proto: Make Channel explicitly Arc<.>

2024-05-16T16:24:12Z

Previously, Channel was a type that you could Clone that implicitly its state. Now, Channel always appears as an Arc. This change has several benefits: * It makes the relationship between Channel struct and the underlying channel more clear. * It enables Channel to participate in the RPC system, where everything has to be an Arc<.> * It enables us to have a Weak, if we ever want to. * It will let us move various members out of ChannelDetails. We did this change a while ago with ClientCirc.

Re-run maint/add_warning.

2024-05-06T13:31:35Z

This commit is automatically generated.

Run maint/add_warning.

2024-03-13T16:30:53Z

deny clippy::unchecked_duration_subtraction

2024-02-29T17:16:49Z

educe: Use std's default for enums where default variant is unit

2024-02-12T11:38:36Z

Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible.

ChannelState::ready_to_expire: return true when rem time is zero

2023-12-14T01:12:10Z

This fixes a race condition that would normally be fairly benign - it would result in scheduling to check for expired channels again immediately, and assuming non-zero time passes would then remove the channel. In Shadow's default time model though, zero time passes in this case, so we just keep scheduling to check again immediately forever; i.e. deadlock.