mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.3 2021-12-28T20:15:40Z 2021-12-28T20:15:40Z Daniel Eades danieleades@hotmail.com 2021-12-28T20:15:40Z urn:sha1:592642a9e6c1c03e525f8b452f4b97e6fd17ff9b 2021-12-14T18:45:19Z Neel Chauhan neel@neelc.org 2021-12-14T18:45:19Z urn:sha1:e67d4e08213094c74685da72db26a4e01c4d8b00 2021-12-07T17:00:40Z eta tor@eta.st 2021-12-02T11:44:29Z urn:sha1:b14c5f370eef0a4fc1d2504ce54de1a921472567 `tor-rtcompat`'s `TlsConnector` trait previously included a method to create a TLS-over-TCP connection, which implied creating a TCP stream inside that method. This commit changes that, and makes the function wrap a TCP stream, as returned from the runtime's `TcpProvider` trait implementation, instead. This means you can actually override `TcpProvider` and have it apply to *all* connections Arti makes, which is useful for issues like arti#235 and other cases where you want to have a custom TCP stream implementation. This required updating the mock TCP/TLS types in `tor-rtmock` slightly; due to the change in API, we now store whether a `LocalStream` should actually be a TLS stream inside the stream itself, and check this property on reads/writes in order to detect misuse. The fake TLS wrapper checks this property and removes it in order to "wrap" the stream, making reads and writes work again. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. 2021-12-04T20:42:53Z Nick Mathewson nickm@torproject.org 2021-12-04T20:42:53Z urn:sha1:66d5f73b9ca8f0d2e4f143d9c7c5a0b162bb3e73 The redundant method was a `to_owned` that probably shouldn't have been called that. It was only used in one place. The tests should get tor-linkspec's line coverage up above 90%. 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d 2021-11-04T14:54:47Z Nick Mathewson nickm@torproject.org 2021-11-04T14:54:47Z urn:sha1:dae8cdb463d94b444ecd465f3a52fdc5a8ed3ede 2021-11-03T13:19:45Z eta tor@eta.st 2021-11-03T12:48:54Z urn:sha1:e8e9699c3c239d6c30f9ad414f15d3bad6ec03fd Instead of awkwardly sharing the internals of a `tor-proto` `Channel` between the reactor task and any other tasks, move most of the internals into the reactor and have other tasks communicate with the reactor via message-passing to allocate circuits and send cells. This makes a lot of things simple, and has convenient properties like not needing to wrap the `Channel` in an `Arc` (though some places in the code still do this for now). A lot of test code required tweaking in order to deal with the refactor; in fact, fixing the tests probably took longer than writing the mainline code (!). Importantly, we now use `tokio`'s `tokio::test` annotation instead of `async_test`, so that we can run things in the background (which is required to have reactors running for the circuit tests). This is an instance of #205, and also kind of #217. 2021-10-28T16:41:08Z Nick Mathewson nickm@torproject.org 2021-10-28T16:41:08Z urn:sha1:e6c0fbaa10ccf732582fb1afc033438285512553 2021-10-21T17:48:06Z Nick Mathewson nickm@torproject.org 2021-10-21T17:48:06Z urn:sha1:55ef69724ce229b2d28b83be2cb3b80fc5a6b35f