mirrors/arti.git/crates/tor-chanmgr/src, branch arti-1.2.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-1.2.1 2024-03-13T16:30:53Z Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c deny clippy::unchecked_duration_subtraction 2024-02-29T17:16:49Z trinity-1686a trinity@deuxfleurs.fr 2024-02-29T17:06:46Z urn:sha1:ac5b36027ca825d27ef466501c660ce498fd9e3c educe: Use std's default for enums where default variant is unit 2024-02-12T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-02-12T11:07:42Z urn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. ChannelState::ready_to_expire: return true when rem time is zero 2023-12-14T01:12:10Z Jim Newsome jnewsome@torproject.org 2023-12-14T01:00:37Z urn:sha1:197c5c8b804ed81c6081472ffea84c95a7f621a7 This fixes a race condition that would normally be fairly benign - it would result in scheduling to check for expired channels again immediately, and assuming non-zero time passes would then remove the channel. In Shadow's default time model though, zero time passes in this case, so we just keep scheduling to check again immediately forever; i.e. deadlock. ChannelState::ready_to_expire: refactor using let-else 2023-12-14T01:12:10Z Jim Newsome jnewsome@torproject.org 2023-12-14T00:56:42Z urn:sha1:cc2cbad83958373a5ada310f3d3cab0a49de656d continually_expire_channels: don't round off expiration delay 2023-12-14T00:51:39Z Jim Newsome jnewsome@torproject.org 2023-12-14T00:51:39Z urn:sha1:cc9d656ca88d75970cc527af1299e9a1e292b008 Without this change, if the delay is less than one second, the code will effectively busy-loop until the delay has elapsed. This potentially leads to deadlock in shadow simulations, and wastes CPU in real usage. https://shadow.github.io/docs/guide/limitations.html?highlight=busy#busy-loops continually_expire_channels: refactor using let-else 2023-12-14T00:50:32Z Jim Newsome jnewsome@torproject.org 2023-12-14T00:50:32Z urn:sha1:10aff4d04e1a404f7f04fde93980184d5b613fb2 oneshot: Apply deferred rustfmt churn 2023-10-11T15:19:46Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-11T15:09:09Z urn:sha1:665ba4f6b6ed2de6f723177d5472e7ee1440599e cargo fmt, precisely. oneshot: Use veneer in tor-chanmgr 2023-10-11T15:19:21Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-11T14:08:39Z urn:sha1:d8a600113c37499dd05ef99c1c6e30a9d3fa10a7 Add initial support for running a PT in server mode 2023-08-24T17:03:38Z Saksham Mittal gotlouemail@gmail.com 2023-08-24T17:03:38Z urn:sha1:bbed17ba4a44a4690ad68e34844329d6542cc184