mirrors/arti.git/crates/tor-chanmgr/src/transport, branch arti-v1.3.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.2 2024-10-01T12:57:42Z tor-socksproto: Handle 0-byte reads (EOF) correctly 2024-10-01T12:57:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-25T18:14:07Z urn:sha1:369391a58cbddac054b494ac53bdd7973610994a This restores the functionality of socks users: detect closed sockets. 0c595818f713916d94b7b0e4062f953fad7c9799 which we reverted as part of rebasing this branch onto main. tor-chanmgr: Use new tor-socksproto API (fmt) 2024-10-01T12:57:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-19T15:51:50Z urn:sha1:7489c18de1f564136de43b906621a28abb715caf tor-chanmgr: Use new tor-socksproto API 2024-10-01T12:57:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-19T15:08:52Z urn:sha1:46e06a3c08351c3855dbe056b9ac0e6ad21cbf3f Apply deferred rustfmt churn 2024-10-01T12:54:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-19T12:50:39Z urn:sha1:c2e1b4bcc8a8f1dca4cc2d8cba60700fecb19976 tor-socksproto: Move `handshake` to be a trait method 2024-10-01T12:54:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-12T14:51:11Z urn:sha1:2e496795b0583ff5d09e436ac7b00eb18beea1f0 This deduplicates some docs and eliminates the two wrapper functiosn for `run_handshake`, which is now just `handshake`. We're going to make other API breaks too, and this isn't going to be the primary API, so we might as well do this. Proper description of the semver breakage will come at the end when it's all done. Revert "socks users: detect closed sockets." 2024-10-01T12:51:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-25T18:18:27Z urn:sha1:844fc25f501729256ce8fbc63c5c1b48fa82f1aa This reverts commit 0c595818f713916d94b7b0e4062f953fad7c9799. Revert "socks users: copy the correct amount in our drain logic." 2024-10-01T12:51:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-25T18:02:53Z urn:sha1:2f2f4a69699e702637452e50d4440584715ab6bd This reverts commit dceeb82f7d1154894ab9c7c607d68f8335bb9615. socks users: copy the correct amount in our drain logic. 2024-09-24T20:55:25Z Nick Mathewson nickm@torproject.org 2024-09-24T20:55:25Z urn:sha1:dceeb82f7d1154894ab9c7c607d68f8335bb9615 When calling copy_within, we want to copy the amount of data that we're keeping; previously, we were copying an extra `action.drain` bytes, which could have led to a panic. Spotted by Opara. socks users: detect closed sockets. 2024-09-24T20:35:07Z Nick Mathewson nickm@torproject.org 2024-09-24T18:16:42Z urn:sha1:0c595818f713916d94b7b0e4062f953fad7c9799 Without this check, our socks code can enter an infinite loop if a socket is closed at the wrong time. Resolves TROVE-2024-011. Fixes #1635. rtcompat: Rename TcpProvider to NetStreamProvider. 2024-09-24T13:10:11Z Nick Mathewson nickm@torproject.org 2024-09-19T11:55:22Z urn:sha1:8c2d84000e4d5ba74e7b6b4e9dac3fc700f618b5 (And similarly rename TcpListener to NetStreamListener, along with their TcpStream/TcpListener associated types.) These types are about to become generic over addresses, and therefore shouldn't be named after TCP. Renaming was done mostly with Rust Analyzer, except for some macros that needed to be hand-edited. (I'll revise the comments in the next commit; this one is all about renaming.)