mirrors/arti.git/crates/tor-chanmgr/src/transport/default.rs, branch arti-v1.3.2mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.22024-09-24T13:10:11Zrtcompat: Rename TcpProvider to NetStreamProvider.2024-09-24T13:10:11ZNick Mathewsonnickm@torproject.org2024-09-19T11:55:22Zurn:sha1:8c2d84000e4d5ba74e7b6b4e9dac3fc700f618b5
(And similarly rename TcpListener to NetStreamListener,
along with their TcpStream/TcpListener associated types.)
These types are about to become generic over addresses,
and therefore shouldn't be named after TCP.
Renaming was done mostly with Rust Analyzer,
except for some macros that needed to be hand-edited.
(I'll revise the comments in the next commit;
this one is all about renaming.)
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cRun maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Throughout: Use *_report!() macros for reporting Errors.2023-07-07T17:00:21ZNick Mathewsonnickm@torproject.org2023-07-07T13:54:27Zurn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
Use ErrorReport for errors in warn! in tor-chanmgr2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:14:37Zurn:sha1:410fdc9f3214040a5fc8c1f267ab919a922598daAllow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
chanmgr: trace-level logs when launching connections.2023-01-06T17:19:00ZNick Mathewsonnickm@torproject.org2022-12-06T13:49:55Zurn:sha1:1e25a962a7c0a47e10a0648eadee8c6c9aa5615b
Based on more temporary debugging code. Yet another part of #677.
Rename TransportHelper => TransportImplHelper.2022-11-30T18:05:46ZNick Mathewsonnickm@torproject.org2022-11-30T18:05:46Zurn:sha1:acc2de7b31625c5c9664eca3d699686ae4601c8ftor-chanmgr: Invent [Box]ChanSensitive for two error payloads2022-11-23T18:28:38ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-23T15:05:58Zurn:sha1:e635383dfb6662ec8f26a2c2549f30ba78b7f514
This
1. Makes the errors smaller (in the case of Io's PtTargetAddr;
ChannelBuild's addresses are already indirected in a Vec).
2. Redacts (currently, scrubs) the PtTargetAddr and SocketAddr
when safe logging is enabled
These are the remaining error variants in tor-chanmgr that contain
information that should become sensitive as part of bridge support.