mirrors/arti.git/crates/tor-chanmgr/src/mgr/map, branch arti-v1.0.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.0.12022-08-24T17:10:12Zfix nightly lints2022-08-24T17:10:12Ztrinity-1686atrinity@deuxfleurs.fr2022-08-24T17:10:12Zurn:sha1:075ec7557f60ef3ef378b75346a69c51f0b4eaf0channel padding: Move initial config of ChannelPaddingInstructions2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-11T10:58:31Zurn:sha1:8339558ba89e65e9994a74eaae66ef9da418fa84
Making ChannelPaddingInstructions::default() accurately reflect the
initial state of the reactor's padding timer simplifies the code
somewhat.
(When padding is wanted, parameters are computed and inserted
explicitly, so the only change is that if we start out dormant, we
defer setting the timer parameters until necessary.)
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827249
channel usage: Rename CU::UserTraffic from CU::Exit2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-11T10:39:39Zurn:sha1:3aed28acd42dbf5342932e2f6f42cc2ddbbe8c50
As suggested in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827246
tor-chanmgr tests: Fix a minimal-versions failure (actually)2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-10T09:42:00Zurn:sha1:c97ea4fce08e7aa4af178590e78da2646e969ff1tor-chanmgr tests: Fix a minimal-versions failure2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T18:24:03Zurn:sha1:a892a3ee625322fade54f7cefbb9c2ee8550f037channel padding: Correctly always send the timer parameters2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T11:32:49Zurn:sha1:46885ac14b9abd93c9bbd1ccc929a02ced0c5c41
Fixes "chanmgr configuration: Avoid sending needless initial update(s)"
Rename ChannelsParams types to ChannelPaddingInstructions2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T09:49:46Zurn:sha1:94dd3361e24335c187bbf4d3a3ec0971b186da3c
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826167
This makes some lines too long; I will run rustfmt in a separate
commit for clarity.
Channel: Make mutable() and engage_padding_activities infallible2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T16:09:14Zurn:sha1:03d8a09c0ea8213abd6430be9c62ad42f8ca2d82
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826151
This gets rid of quite some Bug error paths.
Move ChannelUsage from tor_proto to tor_chanmgr2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T15:33:33Zurn:sha1:5db974ef72eb1250ab27cd7e21141f64d8778776
Replace Channel::note_usage with Channel::engage_padding_activities,
which unconditionally causes the channel to (start to) do netflow
padding things.
The condition now lives in chanmgr.
Addresses
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826094
chanmgr padding_parameters: Use Option2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T14:53:12Zurn:sha1:18827b7fd0b12701c148f94f9618be521b0390b1
The network consensus parameters use (0,0) to mean "no padding"
(which is not the same as (0,0) means in a PADDING_NEGOTIATE cell).
Representing "no padding" this way is actually quite convoluted and
un-Rustic. Ensure that we convert (0,0) to None, and do the primary
logic in Option.