mirrors/arti.git/crates/tor-chanmgr/src/mgr.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-08-23T09:34:00ZRun maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acMerge branch 'clippy-allow' into 'main'2023-07-11T09:37:42ZIan Jacksoniwj@torproject.org2023-07-11T09:37:42Zurn:sha1:3acc2af4f3411588f80669ae1980679dd260b119
clippy: Allow some of our existing code patterns
See merge request tpo/core/arti!1396rng ranges: Use gen_range_checked().expect() in obvious cases (fmt)2023-07-10T15:07:18ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T15:17:32Zurn:sha1:332285015f7d8c4a4e4edd260425bb06f7399e75rng ranges: Use gen_range_checked().expect() in obvious cases2023-07-10T15:07:18ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-07T12:47:04Zurn:sha1:5e10805ede1cc1452d37fa3fb8841127f3060a88
In each of these, it is locally obvious that the range is nonempty.
Run maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
test lint blocks: Add many many automatically2022-12-12T18:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-12-12T17:58:40Zurn:sha1:125a455bdcca841931f33f83f206e57637ae85c4
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
chanmgr: remove a now-stale TODO.2022-11-29T16:15:36ZNick Mathewsonnickm@torproject.org2022-11-29T16:15:36Zurn:sha1:c6aa587dc8d105729da6081351206aaf8fd767c4tor-chanmgr: Introduce the BootstrapReporter API, publicize ChanBuilder2022-11-28T18:52:21Zetator@eta.st2022-11-28T15:32:56Zurn:sha1:a3c9fc5b1aa9f1072448fdea336f561b71ce1176
This commit makes the `ChanBuilder` type in `tor-chanmgr` usable by
consumers outside of that crate, like the doc comment for
`ChannelFactory` says you need to be able to do in order to turn your
`TransportHelper` into something useful.
As part of doing this, the `event_sender` its constructor takes needed
to be dealt with, since it was a crate-internal type that came from
inside the `ChanMgr`.
Enter `BootstrapReporter`: an opaque wrapper around that sender, now
provided as an additional argument to
`ChannelFactory::connect_via_transport`. You can now construct a
`ChanBuilder` outside this crate, and it'll still be able to report its
bootstrap status by unwrapping this new type that's threaded through
from the `ChanMgr`. (This was a fair deal of manually threading the type
through all the layers in this crate!)
Note that you cannot implement bootstrap updating using something that
isn't `ChanBuilder` yet due to the type being entirely opaque (but, of
course, we can figure out exactly what API the reporter should have
later, and add that capability in).
ChanMgr: Fix a few more conditional-compilation issues2022-11-23T16:10:34ZNick Mathewsonnickm@torproject.org2022-11-23T16:01:00Zurn:sha1:1249bedbb0d58c9c4f11c0e9bd589ea5587e47f8