mirrors/arti.git/crates/tor-chanmgr/src/mgr.rs, branch arti-v1.0.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.0.02022-08-17T09:54:41Zchannel usage: Rename CU::UserTraffic from CU::Exit2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-11T10:39:39Zurn:sha1:3aed28acd42dbf5342932e2f6f42cc2ddbbe8c50
As suggested in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827246
channel engage_padding_activities: swap docs to tor0proto2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T10:58:46Zurn:sha1:299f302f355ba150777673902a00079ca6143fe1
This allow us to make a working cross-reference.
Rename ChannelsParams types to ChannelPaddingInstructions (fmt)2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T09:50:40Zurn:sha1:949e5395e0a9bc5827c05ca9b028ff08e07900f3
Run rustfmt; no other changes.
Rename ChannelsParams types to ChannelPaddingInstructions2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-09T09:49:46Zurn:sha1:94dd3361e24335c187bbf4d3a3ec0971b186da3c
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826167
This makes some lines too long; I will run rustfmt in a separate
commit for clarity.
Channel: Make mutable() and engage_padding_activities infallible2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T16:09:14Zurn:sha1:03d8a09c0ea8213abd6430be9c62ad42f8ca2d82
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826151
This gets rid of quite some Bug error paths.
Move ChannelUsage from tor_proto to tor_chanmgr2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T15:33:33Zurn:sha1:5db974ef72eb1250ab27cd7e21141f64d8778776
Replace Channel::note_usage with Channel::engage_padding_activities,
which unconditionally causes the channel to (start to) do netflow
padding things.
The condition now lives in chanmgr.
Addresses
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826094
chanmgr: Use NetDirProvider::params and Arc<dyn..Netparameters>2022-08-17T09:54:41ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-08T12:47:02Zurn:sha1:48fc5d3c39ccb8de3d3b52f34c5c76cae6806714
This gets rid of many Result(). Many parameters are renamed.
Test cases of the now-impossible branch are removed.
Deleting the match from padding_parameters will come in a moment.
I've split off that commit since it has much whitespace noise.
for now, change the error type to Void.
chanmgr testing: FakeChannel: retain the ChannelsParamsUpdates2022-08-16T17:43:23ZIan Jacksonijackson@chiark.greenend.org.uk2022-08-02T10:07:18Zurn:sha1:e4e06f66ec4022c219f0db99b42beea0da442ac0chanmgr configuration: Avoid sending needless initial update(s)2022-08-16T17:43:23ZIan Jacksonijackson@chiark.greenend.org.uk2022-07-25T14:01:50Zurn:sha1:d8972e2cde57a929038e1d46bad7687d62e1e208
Change ChannelsParams::initial_update to compare fields with their
default values, and, if they're the same as the default, not to
include them in the returned update.
And if that update is then empty, return None.
The overall effect is to avoid the call to chan.reparameterize if
we're using the builtin default parameters, which is usual.
chanmgr configuration: Hadle lack of a NetDir2022-08-16T17:43:23ZIan Jacksonijackson@chiark.greenend.org.uk2022-07-27T20:03:16Zurn:sha1:16942963274d08873dfab3a138cd4fa8a9d79ccd
Now that the code that actually handles the netdir information can
cope with its lack, we can change the types of the various netdir
parameters and get rid of the foolish Bugs.