mirrors/arti.git/crates/tor-chanmgr/src/lib.rs, branch arti-v1.1.6mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.62023-06-28T19:26:22ZChanMgr: Tweak documentation a bit.2023-06-28T19:26:22ZNick Mathewsonnickm@torproject.org2023-06-27T15:51:04Zurn:sha1:4ad1a5c6ac96acad510b01e23753b9d746129f84
Adjust formatting, add more references to lower-level APIs, and
clarify lifetimes a little more.
Add Channel expiry info in ChanMgr docs2023-06-27T12:54:56ZSaksham Mittalgotlouemail@gmail.com2023-06-27T12:54:56Zurn:sha1:d6626acd658caab7bb74ece9c4a6a1472dcbc6eblints: Run maint/add_warning to actually apply new lints2023-06-21T11:15:41ZIan Jacksonijackson@chiark.greenend.org.uk2023-06-21T10:29:46Zurn:sha1:161b9844dae0aaa2e63bbc77c512d061be6bb390Use ErrorReport for errors in error! in tor-chanmgr2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:39:14Zurn:sha1:8c1830090cab7aefa673d96b952cda8394a203c7Disable clippy::unlinlined-format-args2023-01-27T13:27:47ZNick Mathewsonnickm@torproject.org2023-01-27T12:49:39Zurn:sha1:bf04641c6818cb2c87c6ed9cf463a5710f8919d2
This warning kind of snuck up on us! (See #748) For now, let's
disable it. (I've cleaned it up in a couple of examples, since
those are meant to be more idiomatic and user-facing.)
Closes #748.
Abolish ChanMgr::set_default_transport2022-11-30T16:00:31ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-30T16:00:31Zurn:sha1:ab74506dc9c0a048f0101e6d802054a383b55cee
The comment says
// TODO pt-client: It's not clear to me that we really need this method.
and empirically, deleting it, and its callee, is fine.
Fix ChanMgr APIs for setting PtMgr etc to match what TorClient wants.2022-11-28T22:29:23ZNick Mathewsonnickm@torproject.org2022-11-28T19:40:06Zurn:sha1:3db0e05b39373defed3a83d1f73959c18e502c90tor-chanmgr: Introduce the BootstrapReporter API, publicize ChanBuilder2022-11-28T18:52:21Zetator@eta.st2022-11-28T15:32:56Zurn:sha1:a3c9fc5b1aa9f1072448fdea336f561b71ce1176
This commit makes the `ChanBuilder` type in `tor-chanmgr` usable by
consumers outside of that crate, like the doc comment for
`ChannelFactory` says you need to be able to do in order to turn your
`TransportHelper` into something useful.
As part of doing this, the `event_sender` its constructor takes needed
to be dealt with, since it was a crate-internal type that came from
inside the `ChanMgr`.
Enter `BootstrapReporter`: an opaque wrapper around that sender, now
provided as an additional argument to
`ChannelFactory::connect_via_transport`. You can now construct a
`ChanBuilder` outside this crate, and it'll still be able to report its
bootstrap status by unwrapping this new type that's threaded through
from the `ChanMgr`. (This was a fair deal of manually threading the type
through all the layers in this crate!)
Note that you cannot implement bootstrap updating using something that
isn't `ChanBuilder` yet due to the type being entirely opaque (but, of
course, we can figure out exactly what API the reporter should have
later, and add that capability in).
ChanMgr: Rename Factory -> CompoundFactory2022-11-23T16:10:34ZNick Mathewsonnickm@torproject.org2022-11-23T16:03:03Zurn:sha1:74ebc904e37110380d28c4b36a914522761d0e20Mark set-default-factory API as experimental.2022-11-23T16:10:34ZNick Mathewsonnickm@torproject.org2022-11-23T15:52:22Zurn:sha1:f8e103bb9483d13bcef2f9ab6bb5be458e85f4b6