mirrors/arti.git/crates/tor-chanmgr/src/builder.rs, branch arti-v2.5.0

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

linkspec: Rename all_addrs_allowed_for_extend()

2026-04-09T16:00:09Z

Also set a better error message when validating channel target. Signed-off-by: David Goulet

relay: Pass advertise SocketAddr to channel builder instead of IpAddr

2026-04-09T15:54:35Z

This trickles down to the tor-proto channel handshake code. But, the real need is in the channel builder in order to validate the outbound channel target. Fixes #2440 Signed-off-by: David Goulet

chanmgr: Validate the ChanTarget for both client and relay

2026-04-09T15:49:39Z

It used to be only with the feature = relay but since client can have that feature enabled, we now validate based on channel outbound type instead. Related to #2440 Signed-off-by: David Goulet

tor-{proto,chanmgr}: change how channels accept a CREATE* handler

2026-04-08T15:29:26Z

Instead of giving the `CreateRequestHandler` to the channel after it's constructed, we integrate it into the handshake so that we can give it to the channel constructor. The `ChannelType` is no longer part of the `Channel`. Some of the tests could be cleaned up slightly now that the channel doesn't need the `ChannelType`, but I don't want to conflict with !3853.

tor-chanmgr: add support for a `CreateRequestHandler`

2026-04-08T15:29:26Z

linkspec: Rename has_all_public_addresses()

2026-03-30T15:00:18Z

Signed-off-by: David Goulet

linkspec: Rename has_all_reachable_addresses()

2026-03-30T15:00:18Z

Signed-off-by: David Goulet

linkspec: Rename has_all_valid_port() to has_all_nonzero_port()

2026-03-30T15:00:18Z

Signed-off-by: David Goulet

proto: Rename RelayIdentities to RelayChannelAuthMaterial

2026-03-30T15:00:18Z

This object contains a melting pot of public keys, private keys and certificates. Rename it to reflect that it is channel authentication material and not "identities. https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3791#note_3374454 Signed-off-by: David Goulet