mirrors/arti.git/crates/tor-chanmgr/src/builder.rs, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02023-08-23T09:34:00ZRun maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun maint/add_warning to actually apply new lint allows2023-07-10T12:49:51ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-10T11:19:32Zurn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0Allow clippy::unchecked_duration_subtraction in tests2023-01-27T13:28:02ZNick Mathewsonnickm@torproject.org2023-01-27T13:01:45Zurn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada
This panics on error, and we're fine with a panic on misbehavior in
tests.
test lint blocks: Add many many automatically2022-12-12T18:00:30ZIan Jacksonijackson@chiark.greenend.org.uk2022-12-12T17:58:40Zurn:sha1:125a455bdcca841931f33f83f206e57637ae85c4
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
Merge branch 'renaming' into 'main'2022-11-30T18:58:37ZNick Mathewsonnickm@torproject.org2022-11-30T18:58:37Zurn:sha1:903571353b8959383963ebf50ec8527fdd19a95b
Renaming a couple of items for arti 1.1.0
Closes #623
See merge request tpo/core/arti!916Downgrade a "TODO pt-client" comment2022-11-30T18:22:54ZNick Mathewsonnickm@torproject.org2022-11-30T18:22:54Zurn:sha1:6bd0f92c15b1080c19a7ab196b9998166a7254d1Rename TransportHelper => TransportImplHelper.2022-11-30T18:05:46ZNick Mathewsonnickm@torproject.org2022-11-30T18:05:46Zurn:sha1:acc2de7b31625c5c9664eca3d699686ae4601c8fSeparate BridgeAddr and PtTargetAddr2022-11-30T15:49:34ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-30T15:07:52Zurn:sha1:199a6e0754581c15ca26096989e35aa021412e97
As per
https://gitlab.torproject.org/tpo/core/arti/-/issues/668#note_2858220
This commit is difficult to split up.
The innards of BridgeAddr and PtTargetAddr are still a bit entangled.
tor-chanmgr: Introduce the BootstrapReporter API, publicize ChanBuilder2022-11-28T18:52:21Zetator@eta.st2022-11-28T15:32:56Zurn:sha1:a3c9fc5b1aa9f1072448fdea336f561b71ce1176
This commit makes the `ChanBuilder` type in `tor-chanmgr` usable by
consumers outside of that crate, like the doc comment for
`ChannelFactory` says you need to be able to do in order to turn your
`TransportHelper` into something useful.
As part of doing this, the `event_sender` its constructor takes needed
to be dealt with, since it was a crate-internal type that came from
inside the `ChanMgr`.
Enter `BootstrapReporter`: an opaque wrapper around that sender, now
provided as an additional argument to
`ChannelFactory::connect_via_transport`. You can now construct a
`ChanBuilder` outside this crate, and it'll still be able to report its
bootstrap status by unwrapping this new type that's threaded through
from the `ChanMgr`. (This was a fair deal of manually threading the type
through all the layers in this crate!)
Note that you cannot implement bootstrap updating using something that
isn't `ChanBuilder` yet due to the type being entirely opaque (but, of
course, we can figure out exactly what API the reporter should have
later, and add that capability in).
tor-chanmgr: Invent [Box]ChanSensitive for two error payloads2022-11-23T18:28:38ZIan Jacksonijackson@chiark.greenend.org.uk2022-11-23T15:05:58Zurn:sha1:e635383dfb6662ec8f26a2c2549f30ba78b7f514
This
1. Makes the errors smaller (in the case of Io's PtTargetAddr;
ChannelBuild's addresses are already indirected in a Vec).
2. Redacts (currently, scrubs) the PtTargetAddr and SocketAddr
when safe logging is enabled
These are the remaining error variants in tor-chanmgr that contain
information that should become sensitive as part of bridge support.