mirrors/arti.git/crates/tor-chanmgr/src/builder.rs, branch arti-v1.0.1

tor-chanmgr: don't log addresses so much.

2022-08-25T14:54:50Z

We now log connection attempts at debug!, and mark relay target addresses as sensitive.

Rename ChannelsParams types to ChannelPaddingInstructions (fmt)

2022-08-17T09:54:41Z

Run rustfmt; no other changes.

Rename ChannelsParams types to ChannelPaddingInstructions

2022-08-17T09:54:41Z

As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826167 This makes some lines too long; I will run rustfmt in a separate commit for clarity.

Channel: Make mutable() and engage_padding_activities infallible

2022-08-17T09:54:41Z

As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826151 This gets rid of quite some Bug error paths.

Move ChannelUsage from tor_proto to tor_chanmgr

2022-08-17T09:54:41Z

Replace Channel::note_usage with Channel::engage_padding_activities, which unconditionally causes the channel to (start to) do netflow padding things. The condition now lives in chanmgr. Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826094

Provide ChannelUsage and plumb it all the way down

2022-08-16T17:37:06Z

Channel padding depends on what the channel is being used for. We therefore need to let the channel code know this information. The implementation of the per-channel padding control logic will be in the new note_usage function, which for now is simply a stub. A future commit will introduce a `PaddingControlState` which lives in the channel frontend; consult the doc comment for that type to see why the plumbing through the channel manager terminates in the channel frontend.

channel reparameterize: Change error type

2022-08-16T17:37:06Z

This is going to be able to fail in other ways too, sadly.

Final (?) API revisions for tor-linkspec

2022-08-10T14:39:37Z

With this change, each individual identity type becomes optional. The functions that expose them unconditionally are now in a "legacy" trait that only some downstream types are expected to implement. There are new convenience APIs in HasRelayIds: * to return Option<&keytype>, * to see if one identity-set contains another. This commit will break several downstream crates! For the reviewer's convenience, I will put the fixes for those crates into a series of squash! commits on this one. tor-netdir ---------- Revise tor-netdir to accept optional identities. This required some caveats and workarounds about the cases where we have to deal with a key type that the tor-netdir code does not currently recognize at all. If we start to add more identity types in the future, we may well want more internal indices in this code. tor-proto --------- In order to make tor-proto support optional identities, there were fewer changes than I thought. Some "check" functions needed to start looking at "all the ids we want" rather than at "the two known IDs"; they also needed to accommodate that case where we don't have an ID that we demand. This change will also help with bridges, since we want to be able to connect to a bridge without knowing all of its IDs up front. The protocol currently _requires_ the two current ID types in some places. To deal with that, I added a new `MissingId` error. I also removed a couple of unconditional identity accessors for chanmgr; code should use `target().identity(...)` instead. tor-chanmgr ----------- This is an incomplete conversion: it does not at all handle channel targets without Ed25519 identities yet. It still uses those identities to index its internal map from identity to channel; but it gives a new `MissingId` error type if it's given a channel target that doesn't have one. We'll want to revise the map type again down the road when we implement bridges, but I'd rather not step on the channel-padding work in progress right now. tor-guardmgr ------------ This change is mostly a matter of constructing owned identity types more sensibly, rather than unwrapping them directly. There are some places marked with TODOs where we still depend on particular identity types, because of how the directory protocol works. This will need revisiting when we add bridge support here. tor-circmgr ----------- These changes are just relatively simple API changes in the tests.

tor-linkspec: Refactor out traits to represent a relay's ID set.

2022-08-02T16:40:23Z

We want the set of identities supported by a relay to be extensible in the future with minimal fuss; we'd also like to make working with these ID sets more convenient. To handle that, this commit adds a new trait for "Something that has the same IDs as a relay" and a new object for "an owned representation of a relay's IDs." This commit introduces a similar trait for "Something with a list of SocketAddr, like a relay has." There's no owned equivelent for that, since Vec is already a thing. Closes #428.

ChanMgr: errors: attribute errors to correct address.

2022-07-06T15:51:28Z

Even when keys are relevant, we still don't want to attribute errors to a set of addresses when we have a single address that we're connected with.