mirrors/arti.git/crates/tor-cert/src/encode.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-07-23T10:13:34Ztor-checkable: Rename `TimeBound::check_valid_*` to `if_valid_*`2026-07-23T10:13:34ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-20T16:40:18Zurn:sha1:ca37f30a097696ce2ebd4e9945a4bdaebe086b31
I find these names confusing. To my mind "check" implies a function
returning `Result<(), _>`.
Some other APIs use `unwrap` here but I think `if` is good.
Use new TimeBound name throughout the tree2026-07-16T15:47:50ZIan Jacksonijackson@chiark.greenend.org.uk2026-07-16T14:32:14Zurn:sha1:5f57903ab4a8c280acf8a5bec274c50d5f544fd6maint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-cert: Ed25519CertBuilder: do builder fn rename2026-04-29T16:49:21ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T09:58:04Zurn:sha1:d90b703d0c4bc4ffb9068fb5c25fc78e72743961
Change all call sites.
This completes the rename.
tor-cert: Ed25519CertBuilder: do type rename everywhere2026-04-29T16:49:21ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T09:59:15Zurn:sha1:24f82c54e0d6d58544a2434d3ae12c3795f0b3f8
Abolish the type alias and change call references.
tor-cert: Ed25519CertBuilder: rename from Ed25519CertConstructor2026-04-29T16:49:21ZIan Jacksonijackson@chiark.greenend.org.uk2026-04-28T09:49:21Zurn:sha1:cbada95b4f5536eb90cf8b2ba6dc8d0570c017de
This is a perfectly ordinary builder type. There isn't any reason why
it ought to be called "constructor". And, nowadays, we have things in
tor-netdoc called Constructor that take a different approach.
Briefly, leave a temporary compat alias, to make diffs more comprehensible.
Currently this experimental, so no semver implications.
tor-cert: Port to web-time-compat2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T13:46:52Zurn:sha1:ef910cf3dad3957b3e7560e8f4f53559e9ef27c7cell, proto, cert: Simplify CERTS cell building.2026-03-19T15:43:38ZNick Mathewsonnickm@torproject.org2026-03-19T15:43:38Zurn:sha1:8a4cbe020879ae011c9e02197d824cbe20e2f736
Formerly we required the caller for push_cert_body to specify the
type of the cert that they were pushing. But in nearly every case,
the certificate object that the caller is holding knows what its
own type is! This makes the tor_proto build_certs_cell function
a bit less error-prone, since we don't have to worry about mismatch.
cert: Deduplicate expiry-in-hours logic2026-03-17T13:54:16ZNick Mathewsonnickm@torproject.org2026-03-17T13:54:16Zurn:sha1:d337afeb1023ea51ce85c0c21fe4ec830c096f49
These certificates use a weird expiration format: counting hours
since the unix epoch. Previously we had it implemented in two
different places. This patch centralizes it, since we are about to
become slightly more complicated.
Remove unnecessary `doc(cfg(...))` attributes2025-12-05T02:40:50ZNeel Chauhanneel@neelc.org2025-11-01T23:25:20Zurn:sha1:26b40cb08b6b715ee80e2b9084810e07512a85c6
Fixes part of #2193.
(Edits from nickm: I selected the cases here that I could verify
were correct from immediate context.)
Edited-by: Nick Mathewson <nickm@torproject.org>