mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.8 2024-09-12T11:48:38Z 2024-09-12T11:48:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-11T15:51:40Z urn:sha1:5314741adecad01014a069c4f0ed5018e0f6c207 No semver implications since this wasn't in the last release. 2024-09-11T13:19:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-11T13:13:08Z urn:sha1:1632c48a5a2f5744970b841628261d6062881dee This is item 1 from https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074562 and the alternative to item 2 presented in the 2nd half of https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074648 (Item 3 was done earlier, but now we change the behaviour.) Fixes #1614. 2024-09-11T13:19:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-11T12:04:46Z urn:sha1:98e563764b428e4f1aa87dc34e5fa6b5cf296938 We could call from_possibly_incomplete_slice in these, but that's confusing and distracting. Here we add this constructor, and document it (in terms of the constructor to come), and change the call sites. No functional change. Doing this now will prevent unwanted changes to test behaviours when we change the behaviour of Readers made by Reader::from_slice. 2024-09-10T09:10:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-05T16:03:58Z urn:sha1:6b6d1d2a6c553e6275d391d6cdc6ad2dd404e83a 2024-09-10T09:10:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-09-05T15:39:31Z urn:sha1:38494a86c7146d2bbc7573b9346ad24341491779 This is going to want to do something more complicated (as described in the docs). In this commit we change all the tests that are expecting Truncated errors. That reduces noise in the next commit. 2024-02-13T14:37:11Z Nick Mathewson nickm@torproject.org 2024-02-13T14:37:11Z urn:sha1:b5c70dad02124549a13e25f62c8073fef4a063fe We never actually constructed these before, but now we enforce it at the API level. Part of #1269. 2024-01-02T15:04:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T12:49:55Z urn:sha1:1ba7e8a78f21b5e1c26c87d12e7a77ebb3a8949d 2024-01-02T13:56:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T12:48:56Z urn:sha1:0ce386a24bd5b0490aee28345f90c7ac956a844d Resolves clippy complaints about needless fallible conversions. 2023-11-29T15:55:04Z Nick Mathewson nickm@torproject.org 2023-11-29T15:49:26Z urn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef This code was needed with the old version of dalek-cryptography, which wasn't compatible with up-to-date versions of the `rand` crate(s). But now that we've upgraded, we can drop this. (We could have left it around and deprecated it, but we are already making a breaking change to tor-llcrypto by upgrading dalek-cryptography.) 2023-11-29T15:34:58Z Nick Mathewson nickm@torproject.org 2023-11-21T15:58:29Z urn:sha1:98037a2c788bd901679139178d25f855324637f3 The main changes that we have to adjust for are as follows: * In x25519-dalek: * `StaticSecret` is now behind a feature. * `StaticSecret::new` is deprecated in favor of `StaticSecret::random_from_rng`. * StaticSecret no longer does its own clamping. * In ed25519-dalek: * `SecretKey` has (in effect) been renamed to `SigningKey`. The name `SecretKey` is now an alias for `[u8; 32]`. * `SigningKey` is effectively a keypair, since it contains a public key as well. * `PublicKey` has been renamed to `VerifyingKey`. * The functions to extract a signing key and verifying key have been renamed as you might expect. * `ExpandedSecretKey` has been moved to `hasmat` and no longer implements `sign`. * `ExpanededSecretKey` now has as its elements a scalar and a hash prefix. * Various functions that took `&[u8]` now take `&[u8; N]`. * We no longer need a wrapper for older versions of rand. There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out. This closes #808. There are several changes I want to make before we merge, however. They are marked with TODO DALEK.